[RFC] one line fix in arch/i386/Kconfig

[RFC] one line fix in arch/i386/Kconfig

[Paolo Ciarrocchi]

Hi all,
this is the first time I post a patch to the list,
therefore I'm really not sure if it is correct,
even if it is just a 'one line patch'

If I say that my cpu is not a PentiumIV why
he bothers me about "check for P4 thermal throttling interrupt." ?

This patch show that option only if you select that kind of CPU.

Is it correct ? Does it makes sense ?

Ciao,
		Paolo
		


--- arch/i386/Kconfig.orig	2003-03-07 22:17:58.000000000 +0100
+++ arch/i386/Kconfig	2003-03-07 22:19:29.000000000 +0100
@@ -536,7 +536,7 @@
 
 config X86_MCE_P4THERMAL
 	bool "check for P4 thermal throttling interrupt."
-	depends on X86_MCE && (X86_UP_APIC || SMP)
+	depends on X86_MCE && (X86_UP_APIC || SMP) && MPENTIUM4
 	help
 	  Enabling this feature will cause a message to be printed when the P4
 	  enters thermal throttling.

-- 
______________________________________________
http://www.linuxmail.org/
Now with e-mail forwarding for only US$5.95/yr

Powered by Outblaze

Re: [RFC] one line fix in arch/i386/Kconfig

[H. Peter Anvin]

Followup to:  <20030307220337.5841.qmail@linuxmail.org>
By author:    "Paolo Ciarrocchi" <ciarrocchi@linuxmail.org>
In newsgroup: linux.dev.kernel
>
> Hi all,
> this is the first time I post a patch to the list,
> therefore I'm really not sure if it is correct,
> even if it is just a 'one line patch'
> 
> If I say that my cpu is not a PentiumIV why
> he bothers me about "check for P4 thermal throttling interrupt." ?
> 

Because you might be compiling a kernel for a more baseline CPU, say a
486, but still check for thermal throttle if it's present.

> This patch show that option only if you select that kind of CPU.
> 
> Is it correct ? Does it makes sense ?

No.

	-hpa
-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64

Re: [RFC] one line fix in arch/i386/Kconfig

[Alan Cox]

On Fri, 2003-03-07 at 22:03, Paolo Ciarrocchi wrote:
> If I say that my cpu is not a PentiumIV why
> he bothers me about "check for P4 thermal throttling interrupt." ?
> 
> This patch show that option only if you select that kind of CPU.
> 
> Is it correct ? Does it makes sense ?

We want people to be able to build a kernel which will run on many systems
but still use CPU specific features. 

Re: [RFC] one line fix in arch/i386/Kconfig

[Paolo Ciarrocchi]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>

> On Fri, 2003-03-07 at 22:03, Paolo Ciarrocchi wrote:
> > If I say that my cpu is not a PentiumIV why
> > he bothers me about "check for P4 thermal throttling interrupt." ?
> > 
> > This patch show that option only if you select that kind of CPU.
> > 
> > Is it correct ? Does it makes sense ?
> 
> We want people to be able to build a kernel which will run on many systems
> but still use CPU specific features. 

Ah... ok I see the point, I could compile a kernel with PIII optimizations
and then run it on a PIV. 

But it is a complication in the configuration process.
Do we agree on that ?

How about a config entry:
"Leave only the option related to the CPU I selected" ?

Ciao,
           Paolo




-- 
______________________________________________
http://www.linuxmail.org/
Now with e-mail forwarding for only US$5.95/yr

Powered by Outblaze

Re: [RFC] one line fix in arch/i386/Kconfig

[H. Peter Anvin]

Followup to:  <20030307223202.9244.qmail@linuxmail.org>
By author:    "Paolo Ciarrocchi" <ciarrocchi@linuxmail.org>
In newsgroup: linux.dev.kernel
> > 
> > We want people to be able to build a kernel which will run on many systems
> > but still use CPU specific features. 
> 
> Ah... ok I see the point, I could compile a kernel with PIII optimizations
> and then run it on a PIV. 
> 
> But it is a complication in the configuration process.
> Do we agree on that ?
>

Not really.

> 
> How about a config entry:
> "Leave only the option related to the CPU I selected" ?
> 

What we really need is to separate out "optimize for CPU" and "support
CPU", kind of like gcc has -mcpu= and -march=.

	-hpa
-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64