Re: [PATCH] register_blkdev

Greg KH
2003-03-08T19:59:59Z

On Sat, Mar 08, 2003 at 07:50:28PM +0000, Christoph Hellwig wrote:
> On Sat, Mar 08, 2003 at 11:37:22AM -0800, Greg KH wrote:
> > That's a good start, but why not change that to a simple,
> > HOW_MANY_MINORS_I_WANT, which will work the same way now, but allow us
> > to change to a pure dynamic major/minor allocation scheme in the future
> > by only modifying the register_chr_device() code. Same thing for
> > register_blkdev().
>
> register_blkdev() _IS_ totally meaningless in 2.5. I said this about three
> times in this thread already, when will people actually take a look at
> the code they look at?

I've looked at it, and right now it keeps drivers from registering the
same major number, and provides a pretty string for the requested major,
when the kernel wants to print it out.

Yes, most of the old code and logic is now gone, but can you just remove
the call altogether now? If so, great :)

greg k-h