Re: [PATCH] register_blkdev

Christoph Hellwig
2003-03-07T18:56:18Z

On Fri, Mar 07, 2003 at 07:49:40PM +0100, Andries.Brouwer@cwi.nl wrote:
> The following patch does the following:
>
> - static const char *blkdevs[MAX_BLKDEV]; disappears
> - get_blkdev_list, (un)register_blkdev, __bdevname
> are moved from block_dev.c to genhd.c
> - the third "fops" parameter of register_blkdev was unused;
> now removed everywhere
> - zillions of places had printk("cannot get major") upon
> error return from register_blkdev; removed all of these
> and inserted a single printk in register_blkdev.

IMHO that's a bad change, (un)register_blkdev should just go away
completly.