From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part
Date: Mon, 10 Mar 2003 13:43:57 +0100 [thread overview]
Message-ID: <200303101343.57545.arnd@arndb.de> (raw)
Stephen Rothwell wrote:
+asmlinkage long compat_sys_fcntl64(unsigned int fd, unsigned int cmd,
+ unsigned long arg)
+{
+ mm_segment_t old_fs;
+ struct flock f;
+ long ret;
+
+ switch (cmd) {
+ case F_GETLK:
+ case F_SETLK:
+ case F_SETLKW:
+ ret = get_compat_flock(&f, (struct compat_flock *)arg);
and
-asmlinkage long sys32_fcntl(unsigned int fd, unsigned int cmd, unsigned long arg)
-{
- switch (cmd) {
- case F_GETLK:
- {
- struct flock f;
- mm_segment_t old_fs;
- long ret;
-
- if(get_compat_flock(&f, (struct compat_flock *)A(arg)))
^^^^^^^^
Did you notice the use of the address conversion macro? Maybe I missed
something myself, but I suppose this will fail on s390 if the msb of arg
is not cleared.
Arnd <><
next reply other threads:[~2003-03-11 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-10 12:43 Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-11 12:20 [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part Martin Schwidefsky
2003-03-12 4:44 ` Stephen Rothwell
2003-03-12 5:02 ` Linus Torvalds
2003-03-12 5:22 ` Stephen Rothwell
2003-03-12 5:26 ` Linus Torvalds
2003-03-12 5:57 ` Stephen Rothwell
2003-03-12 11:46 ` David S. Miller
2003-03-11 0:41 Stephen Rothwell
2003-03-04 5:58 Stephen Rothwell
2003-02-28 9:50 sfr
2003-02-28 10:36 ` Andi Kleen
2003-03-01 9:12 ` Anton Blanchard
2003-02-28 4:33 Stephen Rothwell
2003-02-28 8:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303101343.57545.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox