Re: PCI driver module unload race?

Russell King
2003-03-08T19:59:10Z

On Sat, Mar 08, 2003 at 11:12:37AM -0800, Greg KH wrote:
> On Sat, Mar 08, 2003 at 10:47:49AM +0000, Russell King wrote:
> > Hi,
> >
> > What prevents the following scenario from happening? It's purely
> > theoretical - I haven't seen this occuring.
> >
> > - Load PCI driver.
> >
> > - PCI driver registers using pci_module_init(), and adds itself to sysfs.
> >
> > - Hot-plugin a PCI device which uses this driver. sysfs matches the PCI
> > driver, and calls the PCI drivers probe function.
>
> Ugh, yes you are correct, I can't believe I missed this before.
>
> How does this patch look?

Hrm, I'm wondering whether this should be part of the device model
infrastructure. After all, surely every subsystems device driver
which could be a module would need this to prevent unload races?

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux