public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.4] Memleak in Essential RoadRunner HIPPI board driver
@ 2003-03-12 19:08 Oleg Drokin
  0 siblings, 0 replies; only message in thread
From: Oleg Drokin @ 2003-03-12 19:08 UTC (permalink / raw)
  To: alan, linux-kernel, Jes.Sorensen

Hello!

   There is memleak on error exit path. Seems there was some confusion
   in the mind of whoever added that zeroing statement.
   The patch is trivial, 2.5 is not affected.
   Found with help of smatch + enhanced unfree script

Bye,
    Oleg

===== drivers/net/rrunner.c 1.6 vs edited =====
--- 1.6/drivers/net/rrunner.c	Thu Feb 28 16:57:24 2002
+++ edited/drivers/net/rrunner.c	Wed Mar 12 22:05:15 2003
@@ -1216,7 +1216,6 @@
 
 	rrpriv->info = kmalloc(sizeof(struct rr_info), GFP_KERNEL);
 	if (!rrpriv->info){
-		rrpriv->rx_ctrl = NULL;
 		ecode = -ENOMEM;
 		goto error;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-03-12 18:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-12 19:08 [2.4] Memleak in Essential RoadRunner HIPPI board driver Oleg Drokin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox