From: Rogier Wolff <R.E.Wolff@BitWizard.nl>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: alan@redhat.com, linux-kernel@vger.kernel.org,
R.E.Wolff@BitWizard.nl, torvalds@transmeta.com
Subject: Re: Memleak in driver for the Specialix SX series cards.
Date: Wed, 12 Mar 2003 22:05:16 +0100 [thread overview]
Message-ID: <20030312220516.A20780@bitwizard.nl> (raw)
In-Reply-To: <20030312204114.GA28438@linuxhacker.ru>
On Wed, Mar 12, 2003 at 11:41:14PM +0300, Oleg Drokin wrote:
> Hello!
>
> I see there is a memleak in driver for the Specialix SX series cards
> on error exit path in sx_fw_ioctl() (both in 2.4 and 2.5).
> See the patch.
> Found with help of smatch + unfree script.
...
> + kfree (tmp);
> return -EFAULT;
Hi Oleg,
You're right. I left it like this because "root can always mess up the
machine". But once fixed, I agree that it's better this way.
Roger.
--
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* The Worlds Ecosystem is a stable system. Stable systems may experience *
* excursions from the stable situation. We are currently in such an *
* excursion: The stable situation does not include humans. ***************
prev parent reply other threads:[~2003-03-12 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-12 20:41 Memleak in driver for the Specialix SX series cards Oleg Drokin
2003-03-12 21:05 ` Rogier Wolff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030312220516.A20780@bitwizard.nl \
--to=r.e.wolff@bitwizard.nl \
--cc=alan@redhat.com \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox