From: Jens Axboe <axboe@suse.de>
To: Joe Korty <joe.korty@ccur.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bug in 2.4 bh_kmap_irq() breaks IDE under preempt patch
Date: Thu, 13 Mar 2003 16:05:25 +0100 [thread overview]
Message-ID: <20030313150525.GD836@suse.de> (raw)
In-Reply-To: <200303131459.OAA18664@rudolph.ccur.com>
On Thu, Mar 13 2003, Joe Korty wrote:
> > I fixed this in 2.5 ages ago, just didn't get it in 2.4 block-highmem...
> > There's a tiny bit missing from your patch:
> >
> > > + local_irq_save(*flags);
> > local_irq_disable();
> >
> > other than that it's fine. See 2.5 for reference.
>
> local_irq_save() does a local_irq_disable() as part of its function.
indeed, you are right.
--
Jens Axboe
prev parent reply other threads:[~2003-03-13 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-12 22:13 [PATCH] bug in 2.4 bh_kmap_irq() breaks IDE under preempt patch Joe Korty
2003-03-12 23:27 ` Alan Cox
2003-03-13 9:26 ` Jens Axboe
2003-03-13 10:26 ` Marc-Christian Petersen
2003-03-13 10:28 ` Jens Axboe
2003-03-13 11:50 ` Marc-Christian Petersen
2003-03-13 14:59 ` Joe Korty
2003-03-13 15:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030313150525.GD836@suse.de \
--to=axboe@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox