Re: [PATCH] cpu/hw_random cleanups

[Jeff Garzik <jgarzik@pobox.com>]

On Thu, Mar 13, 2003 at 12:06:16PM -0800, H. Peter Anvin wrote:
> Jeff Garzik wrote:
> >For x86 experts, the new cpu cap words are what needs looking over.
> >For example, I wonder if storing Intel's cpuid(0x00000001) ecx
> >register output is wise on older Intel cpus.  I worry about garbage
> >appearing there.  Is that a false worry?
> >
> 
> Yes; it should be completely safe.

noted


> >===== arch/i386/kernel/cpu/centaur.c 1.7 vs edited =====
> >--- 1.7/arch/i386/kernel/cpu/centaur.c	Tue Mar 11 21:35:40 2003
> >+++ edited/arch/i386/kernel/cpu/centaur.c	Thu Mar 13 13:31:08 2003
> >@@ -256,9 +256,10 @@
> > 	if (cpuid_eax(0xC0000000) >= 0xC0000001) {
> > 		set_bit(X86_FEATURE_CENTAUR_EFF, c->x86_capability);
> > 
> 
> There is also no need to set a special feature bit for the existence of 
> the feature flags.  If they are not present the additional capability 
> word will simply be zero.

Thanks, fixed.

	Jeff