* Memleak in Internet PhoneJACK driver
@ 2003-03-13 20:20 Oleg Drokin
0 siblings, 0 replies; only message in thread
From: Oleg Drokin @ 2003-03-13 20:20 UTC (permalink / raw)
To: alan, linux-kernel, eokerson, torvalds
Hello!
There is unfree memory on error return path in ixj_build_filter_cadence().
Trivial patch that applies to both 2.4 and 2.5 is below.
Found with help of smatch + enhanced ufree patch.
Bye,
Oleg
===== drivers/telephony/ixj.c 1.16 vs edited =====
--- 1.16/drivers/telephony/ixj.c Fri Aug 23 04:23:39 2002
+++ edited/drivers/telephony/ixj.c Thu Mar 13 23:15:51 2003
@@ -6001,12 +6001,14 @@
if(ixjdebug & 0x0001) {
printk(KERN_INFO "Could not copy cadence to kernel\n");
}
+ kfree(lcp);
return -EFAULT;
}
if (lcp->filter > 5) {
if(ixjdebug & 0x0001) {
printk(KERN_INFO "Cadence out of range\n");
}
+ kfree(lcp);
return -1;
}
j->cadence_f[lcp->filter].state = 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-03-13 20:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-13 20:20 Memleak in Internet PhoneJACK driver Oleg Drokin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox