[2.4] init/do_mounts.c::rd_load_image() memleak

Oleg Drokin
2003-03-13T20:52:09Z

Hello!

rd_load_image() leaks some memory if it cannot determine source device size,
if it cannot close or open source for ramdisk device.

Probably this is not all that critical, since we most likely panic after
failure to load initrd, but still there is chance that we have valid
root device too, from which we can try to continue to boot.

Found with help of smatch + enhanced unfree script.

Bye,
Oleg

===== init/do_mounts.c 1.35 vs edited =====
--- 1.35/init/do_mounts.c Wed Jan 15 09:42:29 2003
+++ edited/init/do_mounts.c Thu Mar 13 23:56:18 2003
@@ -551,7 +551,7 @@
int in_fd, out_fd;
unsigned long rd_blocks, devblocks;
int nblocks, i;
- char *buf;
+ char *buf = 0;
unsigned short rotate = 0;
#if !defined(CONFIG_ARCH_S390) && !defined(CONFIG_PPC_ISERIES)
char rotator[4] = { '|' , '/' , '-' , '\\' };
@@ -648,7 +648,6 @@
#endif
}
printk("done.\n");
- kfree(buf);

successful_load:
res = 1;
@@ -656,6 +655,8 @@
close(in_fd);
noclose_input:
close(out_fd);
+ if (buf)
+ kfree(buf);
out:
sys_unlink("/dev/ram");
#endif