Re: [2.4] init/do_mounts.c::rd_load_image() memleak

Oleg Drokin
2003-03-14T07:53:38Z

Hello!

On Fri, Mar 14, 2003 at 08:59:57AM +0100, Jens Axboe wrote:

> > > > + if (buf)
> > > > + kfree(buf);
> > > kfree(NULL); is valid - you don't need this check.
> > Almost every place I can think of does just this, so I do not see why this
> > particular piece of code should be different.
> Since when has that been a valid argument? :)

Well, my argument is code uniformness which was always valid as long as it does not
introduce any bugs, I think.
Do you propose somebody should go and fix all
if ( something )
kfree(something);
pieces of code to read just
kfree(something); ?

Bye,
Oleg