From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 14 Mar 2003 03:56:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 14 Mar 2003 03:56:43 -0500 Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:51468 "HELO kroah.com") by vger.kernel.org with SMTP id ; Fri, 14 Mar 2003 03:56:42 -0500 Date: Fri, 14 Mar 2003 00:56:18 -0800 From: Greg KH To: Christoph Hellwig , linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com Subject: Re: [PATCH] i2c driver changes for 2.5.64 Message-ID: <20030314085618.GD3084@kroah.com> References: <20030314005027.GA1923@kroah.com> <10476033153504@kroah.com> <20030314081904.A11701@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030314081904.A11701@infradead.org> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 14, 2003 at 08:19:04AM +0000, Christoph Hellwig wrote: > > +/* Internally used pause function */ > > +void ali15x3_do_pause(unsigned int amount) > > +{ > > + current->state = TASK_INTERRUPTIBLE; > > + schedule_timeout(amount); > > +} > > I think this should be moved to linux/kernel.h as delay() - I've seen > it duplicated in so much code (including XFS) I'll move this. I think I have this in the usb.h header file too :) > > +#ifdef DEBUG > > + printk > > + ("i2c-ali15x3.o: Transaction (pre): STS=%02x, CNT=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, " > > + "DAT1=%02x\n", inb_p(SMBHSTSTS), inb_p(SMBHSTCNT), > > + inb_p(SMBHSTCMD), inb_p(SMBHSTADD), inb_p(SMBHSTDAT0), > > + inb_p(SMBHSTDAT1)); > > +#endif > > use pr_debug() here. In the next round of patches I'm using dev_dbg() and other dev_* functions for the printk calls, now that we have device support for the adapters. thanks, greg k-h