public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Björn Fahller" <bjorn@netinsight.se>
Cc: Oleg Drokin <green@linuxhacker.ru>,
	alan@redhat.com, linux-kernel@vger.kernel.org,
	zubarev@us.ibm.com
Subject: Re: [2.4] Multiple memleaks in IBM Hot Plug Controller Driver
Date: Fri, 14 Mar 2003 00:57:32 -0800	[thread overview]
Message-ID: <20030314085731.GE3084@kroah.com> (raw)
In-Reply-To: <200303140934.44245.bjorn@netinsight.se>

On Fri, Mar 14, 2003 at 09:34:44AM +0100, Björn Fahller wrote:
> On Thursday 13 March 2003 21.45, Oleg Drokin wrote:
> 
> Below, why allocating 2 bytes on heap (str1,) only to non-conditionally free 
> it a few lines further down? Why not keep the two bytes on stack instead? It 
> also seems like a bad idea to strncopy/strcat 1 byte long strings.

Like I previously said, this whole function is a bad dream.  Look at
what is now in 2.5, all of this nonsense is now gone.

thanks,

greg k-h

  reply	other threads:[~2003-03-14  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-13 20:45 [2.4] Multiple memleaks in IBM Hot Plug Controller Driver Oleg Drokin
2003-03-14  0:31 ` Greg KH
2003-03-14 20:14   ` Oleg Drokin
2003-03-14  8:34 ` Björn Fahller
2003-03-14  8:57   ` Greg KH [this message]
2003-03-14  9:54 ` Denis Vlasenko
2003-03-14 10:26   ` Oleg Drokin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030314085731.GE3084@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@redhat.com \
    --cc=bjorn@netinsight.se \
    --cc=green@linuxhacker.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zubarev@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox