public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Manfred Spraul <manfred@colorfullife.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] O(1) proc_pid_readdir
Date: Sun, 16 Mar 2003 23:03:34 -0800	[thread overview]
Message-ID: <20030317070334.GO20188@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0303170719410.15476-100000@localhost.localdomain>

On Sun, 16 Mar 2003, William Lee Irwin III wrote:
>> I'm heavily on the side of deterministic bounds here (these things trip
>> the NMI oopser, so if the bounds aren't deterministic, neither is
>> stability), so I favor manfred's proc_pid_readdir() algorithm.

On Mon, Mar 17, 2003 at 07:22:15AM +0100, Ingo Molnar wrote:
> no, the code in question here is worst-case O(nr_tasks). It is worst-case
> quadratic only if the number of syscalls done during a full 'ps' readdir()
> sequence is considered as well. This thing will never trigger the NMI
> oopser. And in the common-case it has constant overhead.

Hmm. I was under the (false) impression it filled as many as directory
entries as possible given count. Something else strange is going on then.

The NMI oopses are mostly decoded by hand b/c in-kernel (and other)
backtrace decoders can't do it automatically. I might have to generate
some fresh data, with some kind of hack (e.g. hand-coded NMI-based kind
of smp_call_function) to trace the culprit and not just the victim.
The victims were usually stuck in fork() or exit().


-- wli

  reply	other threads:[~2003-03-17  6:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-16 15:52 [RFC] O(1) proc_pid_readdir Manfred Spraul
2003-03-16 20:10 ` William Lee Irwin III
2003-03-16 21:05 ` Ingo Molnar
2003-03-16 21:24   ` Manfred Spraul
2003-03-16 21:35     ` William Lee Irwin III
2003-03-16 21:45       ` Manfred Spraul
2003-03-17  6:22       ` Ingo Molnar
2003-03-17  7:03         ` William Lee Irwin III [this message]
2003-03-17 18:17           ` Manfred Spraul
2003-03-18  0:14             ` William Lee Irwin III
2003-03-18  0:48               ` William Lee Irwin III
2003-03-18  1:22                 ` William Lee Irwin III
2003-03-18  9:25             ` William Lee Irwin III
2003-03-17  6:19     ` Ingo Molnar
2003-03-22 16:02   ` Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030317070334.GO20188@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox