public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andries.Brouwer@cwi.nl
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dev_t [2/3]
Date: Tue, 18 Mar 2003 15:56:42 -0800	[thread overview]
Message-ID: <20030318235642.GF10089@kroah.com> (raw)
In-Reply-To: <UTC200303182202.h2IM2Lx00966.aeb@smtp.cwi.nl>

On Tue, Mar 18, 2003 at 11:02:21PM +0100, Andries.Brouwer@cwi.nl wrote:
> In order not to have to change all drivers, I did
> 
> +int register_chrdev(unsigned int major, const char *name,
> +                   struct file_operations *fops)
> +{
> +       return register_chrdev_region(major, 0, 256, name, fops);
> +}
> 
> so that the old register_chrdev registers a single major
> and 256 minors. Later this can be changed (but see my letter
> to Al last week).

This is nice, thanks.  We don't have to touch the char drivers now.

Ah, I wish we could change that function to be:
int register_chrdev_region(major, num_minors, name, fops)
if it wasn't for the tty drivers wanting to start their minor at 64.

Hm, wait, why can't we just do it that way and not change the tty core
to use the register_chrdev_region() call?  It should still all work
properly, right?  The tty core would ask for 256 minors, and split them
off the same way it currently does.

thanks,

greg k-h

  reply	other threads:[~2003-03-18 23:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-18 22:02 [PATCH] dev_t [2/3] Andries.Brouwer
2003-03-18 23:56 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-03-19  0:22 Andries.Brouwer
2003-03-19  0:35 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030318235642.GF10089@kroah.com \
    --to=greg@kroah.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox