Re: [PATCH] dev_t [2/3]

[Greg KH <greg@kroah.com>]

On Wed, Mar 19, 2003 at 01:22:35AM +0100, Andries.Brouwer@cwi.nl wrote:
>     Ah, I wish we could change that function to be:
>     int register_chrdev_region(major, num_minors, name, fops)
>     if it wasn't for the tty drivers wanting to start their minor at 64.
> 
>     Hm, wait, why can't we just do it that way and not change the tty core
>     to use the register_chrdev_region() call?  It should still all work
>     properly, right?  The tty core would ask for 256 minors, and split them
>     off the same way it currently does.
> 
> # cat /proc/devices | head
> Character devices:
>   1 mem
>   2 pty
>   3 ttyp
>   4 vc/0
>   4 vc/%d
>   4 ttyS%d
>   5 tty
>   5 console
>   5 ptmx
> #

???  That's with 2.5.65 today or your patch?  Hm, ok, I see with your
patch, how it will generate the above result.

But the fact that the tty core today abuses major numbers by overloading
them is no reason to try to fix that broken behavior.

:)

Anyway, it's a minor nit, I just would prefer to have a "num_minors"
request, but am fine with your patch as is for right now.

Nice job.

thanks,

greg k-h