public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Matthew Wilcox <willy@debian.org>,
	linux-kernel@vger.kernel.org, jes@trained-monkey.org
Subject: Re: [PATCH] Fixup warning for acenic
Date: Thu, 20 Mar 2003 15:59:43 +0000	[thread overview]
Message-ID: <20030320155943.GC14520@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <7000000.1048175453@[10.10.2.4]>

On Thu, Mar 20, 2003 at 07:50:55AM -0800, Martin J. Bligh wrote:
> > Please don't delete this table.  At some point when Jes gets his head
> > out of the "must support Linux 1.2" space, this table will be used and
> > then this driver will support hotplugging.
> 
> Fair enough ... but can we wrap it in CONFIG_SOMETHING? or #if 0 ?

If you must, you could wrap it in MODULE.  I don't see the value in
removing every single warning from the kernel build.  If you're intent on
chasing all these pointless things, try installing gcc 3.3 and compiling
a kernel with that.  It'll pump out more warnings than you can shake
a pointy stick at.  Or turn on -W with gcc 2.96 -- it has much the
same effect.  I made an effort to remove some of the -W warnings from
the header files a while ago so I could compile individual files with
-W as I find it tends to point out some mistakes I often make.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

  reply	other threads:[~2003-03-20 15:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-20 15:17 [PATCH] Fixup warning for acenic Matthew Wilcox
2003-03-20 15:50 ` Martin J. Bligh
2003-03-20 15:59   ` Matthew Wilcox [this message]
2003-03-20 16:10     ` Martin J. Bligh
  -- strict thread matches above, loose matches on Subject: below --
2003-03-20  7:50 Martin J. Bligh
2003-03-20 15:47 ` Jes Sorensen
2003-03-20 16:04   ` Christoph Hellwig
2003-03-20 16:11     ` Martin J. Bligh
2003-03-20 19:20       ` Greg KH
2003-03-20 19:13         ` Martin J. Bligh
2003-03-20 19:28           ` Jeff Garzik
2003-03-20 19:30           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030320155943.GC14520@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=jes@trained-monkey.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox