Re: [PATCH] Fixup warning for acenic

Greg KH
2003-03-20T19:19:18Z

On Thu, Mar 20, 2003 at 11:13:43AM -0800, Martin J. Bligh wrote:
> >> > 2.4.9 of course has the newstyle pci interface! And actual hotplug
> >> > PCI support also is in all today singnificant 2.4.9 forks (RH..).
> >> >
> >> > There's even some shim to emulate the pci_driver style interface on
> >> > 2.2.
> >> >
> >> > Anyway, this table has another use, it's used by userland ools like
> >> > installers for selecting the right driver for a given pci device. So
> >> > even if it seems unused from kernelspace it has a use.
> >>
> >> Are they kmem diving? Or parsing source code?
> >
> > They are looking at the modules.pcimap files which are generated from
> > depmod, which pull it from the object files.
>
> Hmmm ... so we're going to get a compiler warning for every hotpluggable
> driver? or is this just an error in the way acenic does it?

The fact that acenic doesn't reference the structure, like other pci
drivers do, is the reason why the warning is there. Once it switches to
use the "new"[1] pci api, the warning will go away.

thanks,

greg k-h

[1] What, isn't it like 2 years old now?