Re: [PATCH] Fixup warning for acenic

Martin J. Bligh
2003-03-20T15:59:57Z

>> > Please don't delete this table. At some point when Jes gets his head
>> > out of the "must support Linux 1.2" space, this table will be used and
>> > then this driver will support hotplugging.
>>
>> Fair enough ... but can we wrap it in CONFIG_SOMETHING? or #if 0 ?
>
> If you must, you could wrap it in MODULE. I don't see the value in
> removing every single warning from the kernel build. If you're intent on

The main value is that it makes it a damned sight easier to catch *real*
errors and warnings.

> chasing all these pointless things, try installing gcc 3.3 and compiling
> a kernel with that. It'll pump out more warnings than you can shake
> a pointy stick at. Or turn on -W with gcc 2.96 -- it has much the
> same effect. I made an effort to remove some of the -W warnings from
> the header files a while ago so I could compile individual files with
> -W as I find it tends to point out some mistakes I often make.

I refuse to use anything so much massively slower than 2.95, when it
produces worse code ;-) 3.3 might be better (I suppose) but is too
experimental for my taste.

M.