From: Pavel Machek <pavel@suse.cz>
To: Andi Kleen <ak@suse.de>
Cc: Arnd Bergmann <arnd@bergmann-dalldorf.de>,
Pavel Machek <pavel@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: share COMPATIBLE_IOCTL()s across architectures
Date: Thu, 20 Mar 2003 20:35:13 +0100 [thread overview]
Message-ID: <20030320193513.GC312@elf.ucw.cz> (raw)
In-Reply-To: <20030320023843.GA22795@wotan.suse.de>
Hi!
> > Why not simply move the common COMPATIBLE_IOCTLs and includes into
> > kernel/compat_ioctl.c or similar? That would IMHO be cleaner and
> > it does not need more preprocessing hacks.
> > There can still be a second init_sys32_ioctl() copy to handle the arch
> > specific list with additional translations.
>
> This would work for COMPATIBLE_IOCTLS, but the conversions handlers
> would need a new asm/ file for the macros. They're declared with assembler
> magic to avoid declaring all the functions. This way you need less files.
include/linux/compat_ioctl.h can be renamed to fs/compat_ioctl.c if
people prefer. I do not know which one is better.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-03-20 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030320001013$67af@gated-at.bofh.it>
[not found] ` <20030320001013$68b4@gated-at.bofh.it>
2003-03-20 1:35 ` share COMPATIBLE_IOCTL()s across architectures Arnd Bergmann
2003-03-20 2:38 ` Andi Kleen
2003-03-20 10:30 ` Arnd Bergmann
2003-03-20 19:35 ` Pavel Machek [this message]
[not found] <20030319232157.GA13415@elf.ucw.cz.suse.lists.linux.kernel>
2003-03-20 0:08 ` Andi Kleen
2003-03-20 19:33 ` Pavel Machek
2003-03-20 20:26 ` Andi Kleen
2003-03-21 10:24 ` Pavel Machek
2003-03-19 23:21 Pavel Machek
2003-03-20 0:01 ` David S. Miller
2003-03-20 19:32 ` Pavel Machek
2003-03-20 20:24 ` Andi Kleen
2003-03-21 10:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030320193513.GC312@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=ak@suse.de \
--cc=arnd@bergmann-dalldorf.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox