From: Greg KH <greg@kroah.com>
To: Dave Jones <davej@codemonkey.org.uk>,
Pavel Machek <pavel@suse.cz>,
linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] More i2c driver changes for 2.5.65
Date: Mon, 24 Mar 2003 19:34:36 -0800 [thread overview]
Message-ID: <20030325033436.GC11874@kroah.com> (raw)
In-Reply-To: <20030325020418.GB8048@suse.de>
On Tue, Mar 25, 2003 at 02:04:19AM +0000, Dave Jones wrote:
> On Mon, Mar 24, 2003 at 05:29:23PM -0800, Greg KH wrote:
>
> > > > + .name = "ADM1021-MAX1617",
> > > Why dash here
> > > > + .name = "LM75 sensor",
> > > And space here? Also you should have
> > > either 2x "sensor" or none at all.
> > What do you mwan "2x"?
>
> The way I parsed it, either have..
> .name = "ADM1021-MAX1617 sensor",
> .name = "LM75 sensor",
>
> or
>
> .name = "ADM1021-MAX1617",
> .name = "LM75",
>
> ie, both, or all. Personally the latter looks better to me.
Ah, yes, that makes more sense now.
Yes, we shouldn't have the "sensor" in the name.
> Especially given the 16 char limit. Aren't these going to
> be in a sysfs heirarchy where its obvious they are sensors
> anyway ? like i2c/sensors/lm75 ?
Yes, they show up as bus/i2c/drivers/
thanks,
greg k-h
next prev parent reply other threads:[~2003-03-25 3:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-22 1:04 [BK PATCH] More i2c driver changes for 2.5.65 Greg KH
2003-03-22 1:04 ` [PATCH] " Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-22 1:04 ` Greg KH
2003-03-25 9:35 ` Pavel Machek
2003-03-25 1:29 ` Greg KH
2003-03-25 2:04 ` Dave Jones
2003-03-25 3:34 ` Greg KH [this message]
2003-03-22 2:33 ` Petr Vandrovec
2003-03-23 8:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030325033436.GC11874@kroah.com \
--to=greg@kroah.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox