From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com
Subject: Re: How to convert i2c adapter drivers into good kernel code
Date: Mon, 24 Mar 2003 23:41:12 -0800 [thread overview]
Message-ID: <20030325074112.GG12590@kroah.com> (raw)
In-Reply-To: <20030325073834.B30897@infradead.org>
On Tue, Mar 25, 2003 at 07:38:34AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 24, 2003 at 11:25:12PM -0800, Greg KH wrote:
> > line in the driver, and replace the LM_VERSION and LM_DATE entries
> > with I2C_VERSION and I2C_DATE to fix that compile time error.
>
> That's bogus. Replace LM_VERSION with the lm_sensors version you took it
> from + lk1 (e.g. "2.7.0-lk1) and LM_DATE with your modification date.
> Or just remove them altogether..
Fine with me, I was just trying to copy what I had seen done for the
other drivers already in the kernel. version and dates don't really
make _any_ sense once the driver is in the kernel, so I'd recommend just
removing them altogether too.
thanks,
greg k-h
prev parent reply other threads:[~2003-03-25 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-25 7:25 How to convert i2c adapter drivers into good kernel code Greg KH
2003-03-25 7:38 ` Christoph Hellwig
2003-03-25 7:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030325074112.GG12590@kroah.com \
--to=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox