* [BK] Bluetooth updates for 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
@ 2003-03-27 1:50 ` Max Krasnyansky
2003-03-27 1:53 ` Johannes Erdfelt
2003-03-27 7:53 ` Linux 2.4.21-pre6 Roger Luethi
` (8 subsequent siblings)
9 siblings, 1 reply; 26+ messages in thread
From: Max Krasnyansky @ 2003-03-27 1:50 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-kernel
Hi Marcelo,
Could you pull a few Bluetooth updates from
bk://linux-bt.bkbits.net/bt-2.4
This will update the following files:
Documentation/Configure.help | 13
drivers/bluetooth/Config.in | 1
drivers/bluetooth/hci_usb.c | 748 +++++++++++++++++++++++----------------
drivers/bluetooth/hci_usb.h | 105 ++++-
include/net/bluetooth/hci.h | 98 ++---
include/net/bluetooth/hci_core.h | 24 -
net/bluetooth/hci_conn.c | 1
net/bluetooth/hci_core.c | 84 ++--
net/bluetooth/hci_sock.c | 104 ++---
net/bluetooth/syms.c | 4
10 files changed, 712 insertions(+), 470 deletions(-)
through these ChangeSets:
<maxk@qualcomm.com> (03/03/24 1.1110)
[Bluetooth] Use atomic allocations in HCI USB functions called under spinlock.
<marcel@holtmann.org> (03/03/21 1.1109)
[Bluetooth] Add help entry for CONFIG_BLUEZ_USB_SCO
This patch adds the missing help entry for CONFIG_BLUEZ_USB_SCO.
<marcel@holtmann.org> (03/03/21 1.1108)
[Bluetooth] Use R1 for default value of pscan_rep_mode
Most devices seem to use R1 for pscan_rep_mode to save power
consumption, so R1 is preferable for default value, if there
is no entry in the inquiry cache. Using R1 will improve the
average of connect time in many cases.
<marcel@holtmann.org> (03/03/20 1.1107)
[Bluetooth] Add support for the Ultraport Module from IBM
This patch adds the specific vendor and product id's for the
Bluetooth Ultraport Module from IBM. This is needed, because
the device itself don't uses the USB Bluetooth class id.
<maxk@qualcomm.com> (03/03/19 1.1106)
[Bluetooth]
Do not submit more than one usb bulk rx request. It crashes uhci.o driver.
<maxk@qualcomm.com> (03/03/19 1.1105)
[Bluetooth]
Support for SCO (voice) over HCI USB
<maxk@qualcomm.com> (03/03/19 1.1053.2.2)
[Bluetooth]
Kill incoming SCO connection when SCO socket is closed.
<maxk@qualcomm.com> (03/03/05 1.953.2.3)
[Bluetooth]
Use very short disconnect timeout for SCO connections.
They cannot be reused and therefor there is no need to
keep them around.
--
Thanks
Max
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [BK] Bluetooth updates for 2.4.21-pre6
2003-03-27 1:50 ` [BK] Bluetooth updates for 2.4.21-pre6 Max Krasnyansky
@ 2003-03-27 1:53 ` Johannes Erdfelt
2003-03-27 17:32 ` Max Krasnyansky
0 siblings, 1 reply; 26+ messages in thread
From: Johannes Erdfelt @ 2003-03-27 1:53 UTC (permalink / raw)
To: Max Krasnyansky; +Cc: Marcelo Tosatti, linux-kernel
On Wed, Mar 26, 2003, Max Krasnyansky <maxk@qualcomm.com> wrote:
> <maxk@qualcomm.com> (03/03/19 1.1106)
> [Bluetooth]
> Do not submit more than one usb bulk rx request. It crashes uhci.o driver.
I don't recall seeing an email about this.
uhci.o should handle this situation correctly.
JE
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK] Bluetooth updates for 2.4.21-pre6
2003-03-27 1:53 ` Johannes Erdfelt
@ 2003-03-27 17:32 ` Max Krasnyansky
0 siblings, 0 replies; 26+ messages in thread
From: Max Krasnyansky @ 2003-03-27 17:32 UTC (permalink / raw)
To: Johannes Erdfelt; +Cc: Marcelo Tosatti, linux-kernel
At 05:53 PM 3/26/2003, Johannes Erdfelt wrote:
>On Wed, Mar 26, 2003, Max Krasnyansky <maxk@qualcomm.com> wrote:
>> <maxk@qualcomm.com> (03/03/19 1.1106)
>> [Bluetooth]
>> Do not submit more than one usb bulk rx request. It crashes uhci.o driver.
>
>I don't recall seeing an email about this.
>uhci.o should handle this situation correctly.
Sorry. My bad. I meant usb-uhci.
usb-uhci does crash in unlink_qh() when one of the multiple bulk rx urbs
is unlinked. I didn't have time to investigate and therefor did not submit
bug report.
Max
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
2003-03-27 1:50 ` [BK] Bluetooth updates for 2.4.21-pre6 Max Krasnyansky
@ 2003-03-27 7:53 ` Roger Luethi
2003-03-27 13:49 ` Jeff Garzik
2003-03-27 8:48 ` Christoph Hellwig
` (7 subsequent siblings)
9 siblings, 1 reply; 26+ messages in thread
From: Roger Luethi @ 2003-03-27 7:53 UTC (permalink / raw)
To: Marcelo Tosatti, Jeff Garzik; +Cc: linux-kernel
On Wed, 26 Mar 2003 21:08:42 -0300, Marcelo Tosatti wrote:
> We are approaching -rc stage. I plan to release -pre7 shortly which should
> fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
via-rhine is still at 1.16 -- broken for the most common Rhine model. I
thought 1.17 was supposed to go into 2.4.21?
Roger
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-27 7:53 ` Linux 2.4.21-pre6 Roger Luethi
@ 2003-03-27 13:49 ` Jeff Garzik
0 siblings, 0 replies; 26+ messages in thread
From: Jeff Garzik @ 2003-03-27 13:49 UTC (permalink / raw)
To: Roger Luethi; +Cc: Marcelo Tosatti, linux-kernel
Roger Luethi wrote:
> On Wed, 26 Mar 2003 21:08:42 -0300, Marcelo Tosatti wrote:
>
>>We are approaching -rc stage. I plan to release -pre7 shortly which should
>>fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
>
>
> via-rhine is still at 1.16 -- broken for the most common Rhine model. I
> thought 1.17 was supposed to go into 2.4.21?
I need to revert pcnet32 to back to 2.4.19 level, and then my batch is
ready for Marcelo -- which includes your via-rhine fixes.
Jeff
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
2003-03-27 1:50 ` [BK] Bluetooth updates for 2.4.21-pre6 Max Krasnyansky
2003-03-27 7:53 ` Linux 2.4.21-pre6 Roger Luethi
@ 2003-03-27 8:48 ` Christoph Hellwig
2003-03-27 10:10 ` mdew
2003-03-27 19:18 ` Linus Torvalds
2003-03-27 10:42 ` Geert Uytterhoeven
` (6 subsequent siblings)
9 siblings, 2 replies; 26+ messages in thread
From: Christoph Hellwig @ 2003-03-27 8:48 UTC (permalink / raw)
To: Marcelo Tosatti, torvalds; +Cc: lkml
On Wed, Mar 26, 2003 at 09:08:42PM -0300, Marcelo Tosatti wrote:
>
> Here goes -pre6.
>
> We are approaching -rc stage. I plan to release -pre7 shortly which should
> fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
*grrr* once again this is not tagged in BK. Could you _please_ ask Linus
for his nice update release, tag and publish script?
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-27 8:48 ` Christoph Hellwig
@ 2003-03-27 10:10 ` mdew
2003-03-27 19:18 ` Linus Torvalds
1 sibling, 0 replies; 26+ messages in thread
From: mdew @ 2003-03-27 10:10 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Marcelo Tosatti, lkml
On Thu, 2003-03-27 at 20:48, Christoph Hellwig wrote:
> On Wed, Mar 26, 2003 at 09:08:42PM -0300, Marcelo Tosatti wrote:
> >
> > Here goes -pre6.
> >
> > We are approaching -rc stage. I plan to release -pre7 shortly which should
> > fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
>
>
> *grrr* once again this is not tagged in BK. Could you _please_ ask Linus
> for his nice update release, tag and publish script?
at one stage it was tagged, just disappeared :)
--
mdew <mdew@mdew.dyndns.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 8:48 ` Christoph Hellwig
2003-03-27 10:10 ` mdew
@ 2003-03-27 19:18 ` Linus Torvalds
1 sibling, 0 replies; 26+ messages in thread
From: Linus Torvalds @ 2003-03-27 19:18 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Marcelo Tosatti, lkml
On Thu, 27 Mar 2003, Christoph Hellwig wrote:
>
> *grrr* once again this is not tagged in BK. Could you _please_ ask Linus
> for his nice update release, tag and publish script?
Hey, I'm a retard. I don't actually do the tagging with a script, since I
usually want to create the tree privately first, and run a final compile
cycle on it. So I tag it by hand, and then I have a script that outputs
a list of commands that I just cut-and-paste directly. It's ugly, but it
works (and it means that running the script doesn't _do_ anything: I have
to actually take one last look at what I'm going to do before I start it
all up).
The "release script" is this piece of crap:
#!/bin/sh
echo "bk export -w ../linux-$2"
echo "bk export -h -tpatch -rv$1.. > ../patch-$2"
echo "export PATH=\$PATH:/home/torvalds/BK/tools"
echo "changelog v$1 v$2 > ../ChangeLog-$2"
echo "shortlog --width=72 < ../ChangeLog-$2 > ../ChangeLog"
echo "cd .."
echo "tar cf linux-$2.tar linux-$2"
echo "gzip -9 patch-$2"
echo "gzip -9 linux-$2.tar"
echo "touch LATEST-IS-$2"
and that's it. I'd just do "../release-script 2.5.66 2.5.67" from my
kernel directory when I want to generate a 2.5.67 release.
Ok, I'm embarrassed to even admit to doing this. Don't rub it in. It's
useful to me because sometimes I don't do a full release - I just want to
pre-generate a change-log of the diff, for example, to judge whether I
forgot about something.
Linus "retard" Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (2 preceding siblings ...)
2003-03-27 8:48 ` Christoph Hellwig
@ 2003-03-27 10:42 ` Geert Uytterhoeven
2003-03-27 11:56 ` Alan Cox
2003-03-27 12:01 ` Jan Knutar
2003-03-27 11:47 ` Meelis Roos
` (5 subsequent siblings)
9 siblings, 2 replies; 26+ messages in thread
From: Geert Uytterhoeven @ 2003-03-27 10:42 UTC (permalink / raw)
To: Marcelo Tosatti, Alan Cox; +Cc: lkml
On Wed, 26 Mar 2003, Marcelo Tosatti wrote:
> Here goes -pre6.
>
> We are approaching -rc stage. I plan to release -pre7 shortly which should
> fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
Is IDE in 2.4.x and 2.5.x now more or less in sync?
I have some m68k (at least for Amiga builtin) IDE updates for 2.5.x, but am
still waiting for the other m68k platforms to send them in. But if 2.4.21 is
approaching very soon, I better hurry up backporting them to 2.4.x...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-27 10:42 ` Geert Uytterhoeven
@ 2003-03-27 11:56 ` Alan Cox
2003-03-27 12:01 ` Jan Knutar
1 sibling, 0 replies; 26+ messages in thread
From: Alan Cox @ 2003-03-27 11:56 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Marcelo Tosatti, lkml
On Thu, 2003-03-27 at 10:42, Geert Uytterhoeven wrote:
> On Wed, 26 Mar 2003, Marcelo Tosatti wrote:
> > Here goes -pre6.
> >
> > We are approaching -rc stage. I plan to release -pre7 shortly which should
> > fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
>
> Is IDE in 2.4.x and 2.5.x now more or less in sync?
At the driver level yes, some of the upper core stuff is very different because
2.5 is rather different.
Alan
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 10:42 ` Geert Uytterhoeven
2003-03-27 11:56 ` Alan Cox
@ 2003-03-27 12:01 ` Jan Knutar
2003-03-27 12:50 ` Jens Axboe
2003-03-27 13:56 ` DervishD
1 sibling, 2 replies; 26+ messages in thread
From: Jan Knutar @ 2003-03-27 12:01 UTC (permalink / raw)
To: lkml
> Is IDE in 2.4.x and 2.5.x now more or less in sync?
Hm, can we ever expect to get cd burning in 2.4.x on ide without
locking up the other device on the channel?
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 12:01 ` Jan Knutar
@ 2003-03-27 12:50 ` Jens Axboe
2003-03-27 13:56 ` DervishD
1 sibling, 0 replies; 26+ messages in thread
From: Jens Axboe @ 2003-03-27 12:50 UTC (permalink / raw)
To: Jan Knutar; +Cc: lkml
On Thu, Mar 27 2003, Jan Knutar wrote:
>
> > Is IDE in 2.4.x and 2.5.x now more or less in sync?
>
> Hm, can we ever expect to get cd burning in 2.4.x on ide without
> locking up the other device on the channel?
During execution of a single command, channel _will_ be locked. This is
not solvable in the driver, it's how ide works. During fixation, for
instance, the channel will be locked...
Now, if you are locked during the _entire_ burn, that points to an ide
scheduling.
--
Jens Axboe
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 12:01 ` Jan Knutar
2003-03-27 12:50 ` Jens Axboe
@ 2003-03-27 13:56 ` DervishD
1 sibling, 0 replies; 26+ messages in thread
From: DervishD @ 2003-03-27 13:56 UTC (permalink / raw)
To: Jan Knutar; +Cc: lkml
Hi Jan :)
Jan Knutar dixit:
> > Is IDE in 2.4.x and 2.5.x now more or less in sync?
> Hm, can we ever expect to get cd burning in 2.4.x on ide without
> locking up the other device on the channel?
I have a VIA motherboard (686b) and I can read a CD while I burn
another in the cdwriter, both in the same IDE channel :?? Certainly
the burning speeds goes down to 10x or less instead of the usual 12x.
My kernel is 2.4.18, BTW.
Raúl Núñez de Arenas Coronado
--
Linux Registered User 88736
http://www.pleyades.net & http://www.pleyades.net/~raulnac
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (3 preceding siblings ...)
2003-03-27 10:42 ` Geert Uytterhoeven
@ 2003-03-27 11:47 ` Meelis Roos
2003-03-27 10:45 ` Bas Vermeulen
2003-03-27 16:25 ` Stephan von Krawczynski
` (4 subsequent siblings)
9 siblings, 1 reply; 26+ messages in thread
From: Meelis Roos @ 2003-03-27 11:47 UTC (permalink / raw)
To: linux-kernel
MT> Here goes -pre6.
MT>
MT> We are approaching -rc stage. I plan to release -pre7 shortly which should
MT> fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
HDLC started generating warnings in some -pre and they are still there:
/oma/compile/linux-2.4/include/linux/modules/hdlc.ver:3: warning: `__ver_register_hdlc_device' redefined
/oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:3: warning: this is the location of the previous definition
/oma/compile/linux-2.4/include/linux/modules/hdlc.ver:5: warning: `__ver_unregister_hdlc_device' redefined
/oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:5: warning: this is the location of the previous definition
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-27 11:47 ` Meelis Roos
@ 2003-03-27 10:45 ` Bas Vermeulen
2003-03-27 14:12 ` Jörn Engel
0 siblings, 1 reply; 26+ messages in thread
From: Bas Vermeulen @ 2003-03-27 10:45 UTC (permalink / raw)
To: Meelis Roos; +Cc: linux-kernel
On Thu, 27 Mar 2003, Meelis Roos wrote:
> MT> Here goes -pre6.
> MT>
> MT> We are approaching -rc stage. I plan to release -pre7 shortly which should
> MT> fixup the remaining IDE problems (thanks Alan!) and -rc1 later on.
>
> HDLC started generating warnings in some -pre and they are still there:
>
> /oma/compile/linux-2.4/include/linux/modules/hdlc.ver:3: warning: `__ver_register_hdlc_device' redefined
> /oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:3: warning: this is the location of the previous definition
> /oma/compile/linux-2.4/include/linux/modules/hdlc.ver:5: warning: `__ver_unregister_hdlc_device' redefined
> /oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:5: warning: this is the location of the previous definition
Try copying .config away, make mrproper, then the normal routine.
That should fix things for you.
Regards,
Bas Vermeulen
--
"God, root, what is difference?"
-- Pitr, User Friendly
"God is more forgiving."
-- Dave Aronson
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 10:45 ` Bas Vermeulen
@ 2003-03-27 14:12 ` Jörn Engel
0 siblings, 0 replies; 26+ messages in thread
From: Jörn Engel @ 2003-03-27 14:12 UTC (permalink / raw)
To: Bas Vermeulen; +Cc: Meelis Roos, linux-kernel
On Thu, 27 March 2003 11:45:18 +0100, Bas Vermeulen wrote:
> On Thu, 27 Mar 2003, Meelis Roos wrote:
> >
> > HDLC started generating warnings in some -pre and they are still there:
> >
> > /oma/compile/linux-2.4/include/linux/modules/hdlc.ver:3: warning: `__ver_register_hdlc_device' redefined
> > /oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:3: warning: this is the location of the previous definition
> > /oma/compile/linux-2.4/include/linux/modules/hdlc.ver:5: warning: `__ver_unregister_hdlc_device' redefined
> > /oma/compile/linux-2.4/include/linux/modules/hdlc_generic.ver:5: warning: this is the location of the previous definition
>
> Try copying .config away, make mrproper, then the normal routine.
> That should fix things for you.
Well, if more that make dep is needed, doesn't this point to a bug in
Config.in and/or Makefile? ;)
I agree, those have less impact, but they should get fixed as well.
Jörn
--
Courage is not the absence of fear, but rather the judgement that
something else is more important than fear.
-- Ambrose Redmoon
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (4 preceding siblings ...)
2003-03-27 11:47 ` Meelis Roos
@ 2003-03-27 16:25 ` Stephan von Krawczynski
2003-03-27 16:51 ` [PATCH] d_alloc_anon for 2.4.21-pre6 Christoph Hellwig
` (3 subsequent siblings)
9 siblings, 0 replies; 26+ messages in thread
From: Stephan von Krawczynski @ 2003-03-27 16:25 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-kernel, Alan Cox
On Wed, 26 Mar 2003 21:08:42 -0300 (BRT)
Marcelo Tosatti <marcelo@conectiva.com.br> wrote:
>
> Here goes -pre6.
> [...]
> o fix ide-scsi hang on SMP boxes
Sorry, no bonus.
Whatever this patch was, it did not work on my box (SMP, ide-scsi). The only
patch that I know of solving complete freeze is attached, diffed to -pre6.
Regards,
Stephan
--- linux1/drivers/scsi/ide-scsi.c 2003-03-27 15:45:55.000000000 +0100
+++ linux2/drivers/scsi/ide-scsi.c 2003-03-27 15:46:49.000000000 +0100
@@ -321,7 +321,7 @@
{
idescsi_scsi_t *scsi = drive->driver_data;
struct request *rq = HWGROUP(drive)->rq;
- idescsi_pc_t *pc = (idescsi_pc_t *) rq->buffer;
+ idescsi_pc_t *pc = rq->special;
int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
u8 *scsi_buf;
unsigned long flags;
@@ -587,7 +587,7 @@
#endif /* IDESCSI_DEBUG_LOG */
if (rq->cmd == IDESCSI_PC_RQ) {
- return idescsi_issue_pc(drive, (idescsi_pc_t *) rq->buffer);
+ return idescsi_issue_pc (drive, rq->special);
}
printk(KERN_ERR "ide-scsi: %s: unsupported command in request "
"queue (%x)\n", drive->name, rq->cmd);
@@ -1083,7 +1083,7 @@
}
ide_init_drive_cmd(rq);
- rq->buffer = (char *) pc;
+ rq->special = pc;
rq->bh = idescsi_dma_bh(drive, pc);
rq->cmd = IDESCSI_PC_RQ;
spin_unlock_irq(&io_request_lock);
^ permalink raw reply [flat|nested] 26+ messages in thread* [PATCH] d_alloc_anon for 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (5 preceding siblings ...)
2003-03-27 16:25 ` Stephan von Krawczynski
@ 2003-03-27 16:51 ` Christoph Hellwig
2003-03-27 22:25 ` J.A. Magallon
2003-03-27 20:41 ` [2.4 patch] fix multiple definitions of ipv6_ext_hdr Adrian Bunk
` (2 subsequent siblings)
9 siblings, 1 reply; 26+ messages in thread
From: Christoph Hellwig @ 2003-03-27 16:51 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
[$BIGNUM repost since August 2002, still zero feedback]
The rewritten 2.5 nfsd export handling introduce a funcion,
d_alloc_anon, to get an dentry for a given inode, either taking
a well-connected one or allocating a new one.
In 2.4 we have the functionality that it does in 2.4 duplicated over
nfsd and all filesystems having their own fh_to_dentry method, and
XFS needs even more instances of this for other handle to dentry
conversations.
This patch adds d_alloc_anon with exactly the same API as in 2.5, but
the 2.4ish functionality instead to the kernel and switches nfsd, fat
and reiserfs over to it.
--- 1.22/fs/dcache.c Thu Jan 23 10:55:22 2003
+++ edited/fs/dcache.c Thu Mar 27 10:22:35 2003
@@ -659,6 +659,53 @@
}
/**
+ * d_alloc_anon - allocate an anonymous dentry
+ * @inode: inode to allocate the dentry for
+ *
+ * This is similar to d_alloc_root. It is used by filesystems when
+ * creating a dentry for a given inode, often in the process of
+ * mapping a filehandle to a dentry. The returned dentry may be
+ * anonymous, or may have a full name (if the inode was already
+ * in the cache). The file system may need to make further
+ * efforts to connect this dentry into the dcache properly.
+ *
+ * When called on a directory inode, we must ensure that
+ * the inode only ever has one dentry. If a dentry is
+ * found, that is returned instead of allocating a new one.
+ *
+ * On successful return, the reference to the inode has been transferred
+ * to the dentry. If %NULL is returned (indicating kmalloc failure),
+ * the reference on the inode has not been released.
+ */
+
+struct dentry * d_alloc_anon(struct inode *inode)
+{
+ struct dentry *dentry;
+ struct list_head *p;
+
+ /* Try to find a dentry. If possible, get a well-connected one. */
+ spin_lock(&dcache_lock);
+ list_for_each(p, &inode->i_dentry) {
+ dentry = list_entry(p, struct dentry, d_alias);
+ if (!(dentry->d_flags & DCACHE_NFSD_DISCONNECTED))
+ goto found;
+ }
+ spin_unlock(&dcache_lock);
+
+ /* Didn't find dentry. Create anonymous dcache entry. */
+ dentry = d_alloc_root(inode);
+ if (dentry)
+ dentry->d_flags |= DCACHE_NFSD_DISCONNECTED;
+ return dentry;
+
+found:
+ dget_locked(dentry);
+ spin_unlock(&dcache_lock);
+ iput(inode);
+ return dentry;
+}
+
+/**
* d_alloc_root - allocate root dentry
* @root_inode: inode to allocate the root for
*
===== fs/fat/inode.c 1.13 vs edited =====
--- 1.13/fs/fat/inode.c Thu Apr 4 21:31:14 2002
+++ edited/fs/fat/inode.c Thu Mar 27 10:22:35 2003
@@ -430,7 +430,6 @@
int len, int fhtype, int parent)
{
struct inode *inode = NULL;
- struct list_head *lp;
struct dentry *result;
if (fhtype != 3)
@@ -477,33 +476,14 @@
if (!inode)
return ERR_PTR(-ESTALE);
-
- /* now to find a dentry.
- * If possible, get a well-connected one
- *
- * Given the way that we found the inode, it *MUST* be
- * well-connected, but it is easiest to just copy the
- * code.
- */
- spin_lock(&dcache_lock);
- for (lp = inode->i_dentry.next; lp != &inode->i_dentry ; lp=lp->next) {
- result = list_entry(lp,struct dentry, d_alias);
- if (! (result->d_flags & DCACHE_NFSD_DISCONNECTED)) {
- dget_locked(result);
- result->d_vfs_flags |= DCACHE_REFERENCED;
- spin_unlock(&dcache_lock);
- iput(inode);
- return result;
- }
- }
- spin_unlock(&dcache_lock);
- result = d_alloc_root(inode);
+
+ result = d_alloc_anon(inode);
if (result == NULL) {
iput(inode);
return ERR_PTR(-ENOMEM);
}
result->d_op = sb->s_root->d_op;
- result->d_flags |= DCACHE_NFSD_DISCONNECTED;
+ result->d_vfs_flags |= DCACHE_REFERENCED;
return result;
===== fs/nfsd/nfsfh.c 1.18 vs edited =====
--- 1.18/fs/nfsd/nfsfh.c Mon Dec 16 17:50:09 2002
+++ edited/fs/nfsd/nfsfh.c Thu Mar 27 10:22:35 2003
@@ -135,7 +135,6 @@
* of 0 means "accept any"
*/
struct inode *inode;
- struct list_head *lp;
struct dentry *result;
if (ino == 0)
return ERR_PTR(-ESTALE);
@@ -155,27 +154,14 @@
iput(inode);
return ERR_PTR(-ESTALE);
}
- /* now to find a dentry.
- * If possible, get a well-connected one
- */
- spin_lock(&dcache_lock);
- for (lp = inode->i_dentry.next; lp != &inode->i_dentry ; lp=lp->next) {
- result = list_entry(lp,struct dentry, d_alias);
- if (! (result->d_flags & DCACHE_NFSD_DISCONNECTED)) {
- dget_locked(result);
- result->d_vfs_flags |= DCACHE_REFERENCED;
- spin_unlock(&dcache_lock);
- iput(inode);
- return result;
- }
- }
- spin_unlock(&dcache_lock);
- result = d_alloc_root(inode);
+
+
+ result = d_alloc_anon(inode);
if (result == NULL) {
iput(inode);
return ERR_PTR(-ENOMEM);
}
- result->d_flags |= DCACHE_NFSD_DISCONNECTED;
+ result->d_vfs_flags |= DCACHE_REFERENCED;
return result;
}
===== fs/reiserfs/inode.c 1.42 vs edited =====
--- 1.42/fs/reiserfs/inode.c Thu Feb 13 07:42:42 2003
+++ edited/fs/reiserfs/inode.c Thu Mar 27 10:22:35 2003
@@ -1249,7 +1249,6 @@
int len, int fhtype, int parent) {
struct cpu_key key ;
struct inode *inode = NULL ;
- struct list_head *lp;
struct dentry *result;
/* fhtype happens to reflect the number of u32s encoded.
@@ -1301,27 +1300,12 @@
if (!inode)
return ERR_PTR(-ESTALE) ;
- /* now to find a dentry.
- * If possible, get a well-connected one
- */
- spin_lock(&dcache_lock);
- for (lp = inode->i_dentry.next; lp != &inode->i_dentry ; lp=lp->next) {
- result = list_entry(lp,struct dentry, d_alias);
- if (! (result->d_flags & DCACHE_NFSD_DISCONNECTED)) {
- dget_locked(result);
- result->d_vfs_flags |= DCACHE_REFERENCED;
- spin_unlock(&dcache_lock);
- iput(inode);
- return result;
- }
- }
- spin_unlock(&dcache_lock);
- result = d_alloc_root(inode);
+ result = d_alloc_anon(inode);
if (result == NULL) {
iput(inode);
return ERR_PTR(-ENOMEM);
}
- result->d_flags |= DCACHE_NFSD_DISCONNECTED;
+ result->d_vfs_flags |= DCACHE_REFERENCED;
return result;
}
===== include/linux/dcache.h 1.12 vs edited =====
--- 1.12/include/linux/dcache.h Sat Aug 3 18:39:21 2002
+++ edited/include/linux/dcache.h Thu Mar 27 15:42:26 2003
@@ -165,6 +165,7 @@
/* allocate/de-allocate */
extern struct dentry * d_alloc(struct dentry *, const struct qstr *);
+extern struct dentry * d_alloc_anon(struct inode *);
extern void shrink_dcache_sb(struct super_block *);
extern void shrink_dcache_parent(struct dentry *);
extern int d_invalidate(struct dentry *);
===== kernel/ksyms.c 1.67 vs edited =====
--- 1.67/kernel/ksyms.c Tue Oct 1 14:34:41 2002
+++ edited/kernel/ksyms.c Thu Mar 27 10:22:36 2003
@@ -164,6 +164,7 @@
EXPORT_SYMBOL(d_move);
EXPORT_SYMBOL(d_instantiate);
EXPORT_SYMBOL(d_alloc);
+EXPORT_SYMBOL(d_alloc_anon);
EXPORT_SYMBOL(d_lookup);
EXPORT_SYMBOL(__d_path);
EXPORT_SYMBOL(mark_buffer_dirty);
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH] d_alloc_anon for 2.4.21-pre6
2003-03-27 16:51 ` [PATCH] d_alloc_anon for 2.4.21-pre6 Christoph Hellwig
@ 2003-03-27 22:25 ` J.A. Magallon
2003-03-27 22:30 ` Christoph Hellwig
0 siblings, 1 reply; 26+ messages in thread
From: J.A. Magallon @ 2003-03-27 22:25 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Marcelo Tosatti, lkml
On 03.27, Christoph Hellwig wrote:
> [$BIGNUM repost since August 2002, still zero feedback]
>
> The rewritten 2.5 nfsd export handling introduce a funcion,
> d_alloc_anon, to get an dentry for a given inode, either taking
> a well-connected one or allocating a new one.
>
> In 2.4 we have the functionality that it does in 2.4 duplicated over
> nfsd and all filesystems having their own fh_to_dentry method, and
> XFS needs even more instances of this for other handle to dentry
> conversations.
>
> This patch adds d_alloc_anon with exactly the same API as in 2.5, but
> the 2.4ish functionality instead to the kernel and switches nfsd, fat
> and reiserfs over to it.
>
The patch I had from time ago in -jam also included this switch to
list_for_each:
diff -uNr -Xdontdiff -p linux-2.4.20-pre4/fs/dcache.c linux/fs/dcache.c
--- linux-2.4.20-pre4/fs/dcache.c Sat Aug 17 14:54:38 2002
+++ linux/fs/dcache.c Tue Aug 20 11:39:48 2002
@@ -247,24 +247,22 @@ struct dentry * dget_locked(struct dentr
struct dentry * d_find_alias(struct inode *inode)
{
- struct list_head *head, *next, *tmp;
- struct dentry *alias;
+ struct dentry *dentry;
+ struct list_head *p;
spin_lock(&dcache_lock);
- head = &inode->i_dentry;
- next = inode->i_dentry.next;
- while (next != head) {
- tmp = next;
- next = tmp->next;
- alias = list_entry(tmp, struct dentry, d_alias);
- if (!list_empty(&alias->d_hash)) {
- __dget_locked(alias);
- spin_unlock(&dcache_lock);
- return alias;
- }
+ list_for_each(p, &inode->i_dentry) {
+ dentry = list_entry(p, struct dentry, d_alias);
+ if (!list_empty(&dentry->d_hash))
+ goto found;
}
spin_unlock(&dcache_lock);
return NULL;
+
+found:
+ __dget_locked(dentry);
+ spin_unlock(&dcache_lock);
+ return dentry;
}
/*
--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.1 (Bamboo) for i586
Linux 2.4.21-pre5-jam1 (gcc 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk))
^ permalink raw reply [flat|nested] 26+ messages in thread
* [2.4 patch] fix multiple definitions of ipv6_ext_hdr
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (6 preceding siblings ...)
2003-03-27 16:51 ` [PATCH] d_alloc_anon for 2.4.21-pre6 Christoph Hellwig
@ 2003-03-27 20:41 ` Adrian Bunk
2003-03-27 20:42 ` David S. Miller
2003-03-28 1:59 ` [PATCH] alpha ptrace fix Re: Linux 2.4.21-pre6 Tom Vier
2003-03-31 18:16 ` Alvaro Figueroa
9 siblings, 1 reply; 26+ messages in thread
From: Adrian Bunk @ 2003-03-27 20:41 UTC (permalink / raw)
To: David S. Miller, laforge; +Cc: lkml
On Wed, Mar 26, 2003 at 09:08:42PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.21-pre5 to v2.4.21-pre6
> ============================================
>...
> <laforge@netfilter.org>:
>...
> o [NETFILTER]: Add new ip6tables matches
>...
#include <deja-vu.h>
<-- snip -->
...
ld -m elf_i386 -r -o netfilter.o ip6_tables.o ip6t_limit.o ip6t_mark.o
ip6t_length.o ip6t_mac.o ip6t_rt.o ip6t_hbh.o ip6t_dst.o ip6t_ipv6header.o
ip6t_frag.o ip6t_esp.o ip6t_ah.o ip6t_eui64.o ip6t_multiport.o ip6t_owner.o
ip6table_filter.o ip6table_mangle.o ip6t_MARK.o ip6_queue.o ip6t_LOG.o
ip6t_hbh.o(.text+0x0): In function `ipv6_ext_hdr':
: multiple definition of `ipv6_ext_hdr'
ip6t_rt.o(.text+0x0): first defined here
...
make[3]: *** [netfilter.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.21-pre6-full-nohotplug/net/ipv6/netfilter'
<-- snip -->
My fix for this issue that went into 2.5.66 is below (it applies
and compiles against 2.4.21-pre6, too).
Please apply
Adrian
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_ah.c.old 2003-03-05 23:30:00.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_ah.c 2003-03-05 23:30:43.000000000 +0100
@@ -26,17 +26,6 @@
__u32 spi;
};
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/* Returns 1 if the spi is matched by the range, 0 otherwise */
static inline int
spi_match(u_int32_t min, u_int32_t max, u_int32_t spi, int invert)
@@ -79,7 +68,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
DEBUGP("ipv6_ah header iteration \n");
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_dst.c.old 2003-03-05 23:30:44.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_dst.c 2003-03-05 23:31:01.000000000 +0100
@@ -29,17 +29,6 @@
#define DEBUGP(format, args...)
#endif
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/*
* (Type & 0xC0) >> 6
* 0 -> ignorable
@@ -84,7 +73,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
DEBUGP("ipv6_opts header iteration \n");
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_esp.c.old 2003-03-05 23:31:02.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_esp.c 2003-03-05 23:31:22.000000000 +0100
@@ -23,17 +23,6 @@
__u32 spi;
};
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/* Returns 1 if the spi is matched by the range, 0 otherwise */
static inline int
spi_match(u_int32_t min, u_int32_t max, u_int32_t spi, int invert)
@@ -74,7 +63,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
int hdrlen;
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_frag.c.old 2003-03-05 23:31:23.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_frag.c 2003-03-05 23:31:45.000000000 +0100
@@ -44,17 +44,6 @@
__u32 id;
};
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/* Returns 1 if the id is matched by the range, 0 otherwise */
static inline int
id_match(u_int32_t min, u_int32_t max, u_int32_t id, int invert)
@@ -93,7 +82,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
DEBUGP("ipv6_frag header iteration \n");
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_hbh.c.old 2003-03-05 23:31:45.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_hbh.c 2003-03-05 23:32:01.000000000 +0100
@@ -29,17 +29,6 @@
#define DEBUGP(format, args...)
#endif
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/*
* (Type & 0xC0) >> 6
* 0 -> ignorable
@@ -84,7 +73,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
DEBUGP("ipv6_opts header iteration \n");
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_ipv6header.c.old 2003-03-05 23:32:02.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_ipv6header.c 2003-03-05 23:32:26.000000000 +0100
@@ -24,17 +24,6 @@
#define DEBUGP(format, args...)
#endif
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
static int
ipv6header_match(const struct sk_buff *skb,
const struct net_device *in,
@@ -95,7 +84,7 @@
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
int hdrlen;
--- linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_rt.c.old 2003-03-05 23:32:26.000000000 +0100
+++ linux-2.5.64-notfull/net/ipv6/netfilter/ip6t_rt.c 2003-03-05 23:32:40.000000000 +0100
@@ -21,17 +21,6 @@
#define DEBUGP(format, args...)
#endif
-int ipv6_ext_hdr(u8 nexthdr)
-{
- return ( (nexthdr == NEXTHDR_HOP) ||
- (nexthdr == NEXTHDR_ROUTING) ||
- (nexthdr == NEXTHDR_FRAGMENT) ||
- (nexthdr == NEXTHDR_AUTH) ||
- (nexthdr == NEXTHDR_ESP) ||
- (nexthdr == NEXTHDR_NONE) ||
- (nexthdr == NEXTHDR_DEST) );
-}
-
/* Returns 1 if the id is matched by the range, 0 otherwise */
static inline int
segsleft_match(u_int32_t min, u_int32_t max, u_int32_t id, int invert)
@@ -71,7 +60,7 @@
len = skb->len - ptr;
temp = 0;
- while (ipv6_ext_hdr(nexthdr)) {
+ while (ip6t_ext_hdr(nexthdr)) {
struct ipv6_opt_hdr *hdr;
DEBUGP("ipv6_rt header iteration \n");
--- linux-2.5.64-notfull/include/linux/netfilter_ipv6/ip6_tables.h.old 2003-03-05 23:36:49.000000000 +0100
+++ linux-2.5.64-notfull/include/linux/netfilter_ipv6/ip6_tables.h 2003-03-05 23:49:51.000000000 +0100
@@ -449,6 +449,9 @@
struct ip6t_table *table,
void *userdata);
+/* Check for an extension */
+extern int ip6t_ext_hdr(u8 nexthdr);
+
#define IP6T_ALIGN(s) (((s) + (__alignof__(struct ip6t_entry)-1)) & ~(__alignof__(struct ip6t_entry)-1))
#endif /*__KERNEL__*/
^ permalink raw reply [flat|nested] 26+ messages in thread* [PATCH] alpha ptrace fix Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (7 preceding siblings ...)
2003-03-27 20:41 ` [2.4 patch] fix multiple definitions of ipv6_ext_hdr Adrian Bunk
@ 2003-03-28 1:59 ` Tom Vier
2003-03-31 18:16 ` Alvaro Figueroa
9 siblings, 0 replies; 26+ messages in thread
From: Tom Vier @ 2003-03-28 1:59 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-kernel
Chris Wright posted this change for alpha that's needed for the ptrace fix.
--
Tom Vier <tmv@comcast.net>
DSA Key ID 0xE6CB97DA
--- linux/arch/alpha/kernel/entry.S.kmod Tue Mar 18 18:17:46 2003
+++ linux-patched/arch/alpha/kernel/entry.S Tue Mar 18 18:18:50 2003
@@ -234,8 +234,8 @@
* arch_kernel_thread(fn, arg, clone_flags)
*/
.align 3
-.globl kernel_thread
-.ent kernel_thread
+.globl arch_kernel_thread
+.ent arch_kernel_thread
arch_kernel_thread:
ldgp $29,0($27) /* we can be called from a module */
.frame $30, 4*8, $26
@@ -265,7 +265,7 @@
mov $0,$16
mov $31,$26
jsr $31,sys_exit
-.end kernel_thread
+.end arch_kernel_thread
/*
* __kernel_execve(path, argv, envp, regs)
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-27 0:08 Linux 2.4.21-pre6 Marcelo Tosatti
` (8 preceding siblings ...)
2003-03-28 1:59 ` [PATCH] alpha ptrace fix Re: Linux 2.4.21-pre6 Tom Vier
@ 2003-03-31 18:16 ` Alvaro Figueroa
2003-03-31 18:35 ` Alan Cox
9 siblings, 1 reply; 26+ messages in thread
From: Alvaro Figueroa @ 2003-03-31 18:16 UTC (permalink / raw)
To: alan, Marcelo Tosatti; +Cc: linux-kernel
On Wed, 2003-03-26 at 18:08, Marcelo Tosatti wrote:
> Here goes -pre6.
> Alan Cox <alan@lxorguk.ukuu.org.uk>:
(...)
> o ali5451 is 31bit audio
Unfortunately, this patch has completely screwed up sound on the Sun
Blade 100.
I was wondering if this patch could be backed up in -pre7.
--
Alvaro Figueroa
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: Linux 2.4.21-pre6
2003-03-31 18:16 ` Alvaro Figueroa
@ 2003-03-31 18:35 ` Alan Cox
0 siblings, 0 replies; 26+ messages in thread
From: Alan Cox @ 2003-03-31 18:35 UTC (permalink / raw)
To: Alvaro Figueroa; +Cc: alan, Marcelo Tosatti, linux-kernel
> > Here goes -pre6.
>
> > Alan Cox <alan@lxorguk.ukuu.org.uk>:
> (...)
> > o ali5451 is 31bit audio
>
> Unfortunately, this patch has completely screwed up sound on the Sun
> Blade 100.
>
> I was wondering if this patch could be backed up in -pre7.
No. Its a bug fix. DaveM is aware of the fact the sparc side needs
some tweaking
^ permalink raw reply [flat|nested] 26+ messages in thread