Re: [PATCH] s390 update (1/9): s390 arch fixes.

[Christoph Hellwig <hch@infradead.org>]

On Thu, Mar 27, 2003 at 01:17:14PM +0100, Martin Schwidefsky wrote:
> 
> > Now actually take a look at this diff :)  The biggest part is that the
> > s390 compat files exist only on s390x and the math-emu dir only exists
> > on s390, that's just a matter of conditionally compiling the files.
> 
> I did look at the diff. Did you?

Yes.

> The patch is 5600 lines. A
> small part of this diff can probably be avoided but you end up with
> 3000-4000 lines of real diff. Because of the size of this a merge of
> s390 and s390x isn't simple and shouldn't be done in a hurry.

My guess is that the difference can be a lot smaller if abstracted
out properly, but that's pretty mood unless someone actually tries it :)

So yes, it's certainly not trivial (otherwise someone would have
already done it), and I didn't say you should hurry to do it.  Also
note that you don't have to do it all at once, start with #including
the s390 files on s390x that are exactly the same, and after that
one file after another can be cleaned up to be s390/s390x clean.