From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] fix .text.exit error in drivers/net/r8169.c
Date: Thu, 27 Mar 2003 23:13:42 +0100 [thread overview]
Message-ID: <20030327221342.GC24744@fs.tum.de> (raw)
In drivers/net/r8169.c the function rtl8169_remove_one is __devexit but
the pointer to it didn't use __devexit_p resulting in a.text.exit
compile error when !CONFIG_HOTPLUG.
The fix is simple:
--- linux-2.4.21-pre6-full-nohotplug/drivers/net/r8169.c.old 2003-03-27 22:17:09.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/net/r8169.c 2003-03-27 22:19:18.000000000 +0100
@@ -1110,7 +1110,7 @@
.name = MODULENAME,
.id_table = rtl8169_pci_tbl,
.probe = rtl8169_init_one,
- .remove = rtl8169_remove_one,
+ .remove = __devexit_p(rtl8169_remove_one),
.suspend = NULL,
.resume = NULL,
};
The patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
compilation with 2.4.21-pre6.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2003-03-27 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-27 22:13 Adrian Bunk [this message]
2003-03-27 22:19 ` [patch] fix .text.exit error in drivers/net/r8169.c Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327221342.GC24744@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox