public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jan Dittmer <j.dittmer@portrix.net>,
	Mark Studebaker <mds@paradyne.com>,
	azarah@gentoo.org, KML <linux-kernel@vger.kernel.org>,
	Dominik Brodowski <linux@brodo.de>,
	sensors@Stimpy.netroedge.com
Subject: Re: lm sensors sysfs file structure
Date: Mon, 31 Mar 2003 22:44:39 -0800	[thread overview]
Message-ID: <20030331224439.A7000@kroah.com> (raw)
In-Reply-To: <20030330192312.GB6666@zaurus.ucw.cz>; from pavel@ucw.cz on Sun, Mar 30, 2003 at 09:23:12PM +0200

On Sun, Mar 30, 2003 at 09:23:12PM +0200, Pavel Machek wrote:
> Hi!
> 
> > > >	       	Floating point values XXX.X or XXX.XX in degrees Celcius.
> > > 
> > > If we're restructuring it, I think we should also agree on _one_ common 
> > > denominator for all values ie. mVolt and milli-Degree Celsius, so that 
> > > no userspace program ever again has know how to convert them to 
> > > user-readable values and every user can just cat the values and doesn't 
> > > have to wonder if it's centi-Volt, milli-Volt, centi-Degree, dezi-Degree 
> > > or whatever.
> > 
> > Um, that's what my proposal stated.  Do you not agree with it?  (You're
> > quoting the existing document above, not my proposed changes.)
> 
> Well, you had cV for PSU voltages and
> mV for cpu core voltage. I guess mV
> and mili-deg-C everywhere would be
> nicer. 

I was trying to keep consistant with what the old /proc values were
reported as.  I'll go fix that up.

As for why no floating point, it's a pain in the but to both output a
fixed point number from the kernel into floating point, and to parse a
floating point number from userspace within the kernel, turning it into
a fixed point number.  With the proposal I wrote up, none of that is
needed, and all userspace has to do is divide by a factor of 10 to get
the proper value.

It's much simpler and easier to validate we got it right code.  If
you're still not convinced take a look at the code in
drivers/i2c/i2c-proc.c::i2c_parse_reals() for an example of some hairy
code...

thanks,

greg k-h

  reply	other threads:[~2003-04-01  6:32 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-25  8:53 i2c driver changes for 2.5.66; adding w83781d support Martin Schlemmer
2003-03-25 17:56 ` Greg KH
2003-03-26 19:04   ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Martin Schlemmer
2003-03-26 19:40     ` Jan Dittmer
2003-03-26 19:54       ` Martin Schlemmer
2003-03-26 20:26       ` Greg KH
2003-03-26 20:43         ` Christoph Hellwig
2003-03-26 21:23           ` Greg KH
2003-03-26 22:26         ` Mark Studebaker
2003-03-26 22:52           ` lm sensors sysfs file structure Greg KH
2003-03-27 10:46             ` Jan Dittmer
2003-03-27 10:50               ` Martin Schlemmer
2003-03-27 12:27                 ` Jan Dittmer
2003-03-27 12:33                   ` Martin Schlemmer
2003-03-27 13:05                     ` Jan Dittmer
2003-03-27 13:31                       ` Jean Delvare
2003-03-27 17:16                         ` Mark M. Hoffman
2003-03-27 17:25               ` Greg KH
2003-03-27 18:06                 ` Jan Dittmer
2003-03-27 18:13                   ` Greg KH
2003-03-30 19:23                 ` Pavel Machek
2003-04-01  6:44                   ` Greg KH [this message]
2003-04-01 20:22                     ` Pavel Machek
2003-04-01 23:27                     ` Dave Jones
2003-04-03  0:28                       ` Greg KH
2003-04-03 10:49                         ` Dave Jones
2003-04-03 18:43                           ` Dominik Brodowski
2003-03-27 18:40             ` Jan Dittmer
2003-03-27 18:52               ` Greg KH
2003-03-27 18:17                 ` Patrick Mochel
2003-03-27 18:57                 ` Jan Dittmer
2003-03-27 19:15                 ` Martin Schlemmer
2003-03-27 19:25                   ` Greg KH
2003-03-27 19:42             ` Greg KH
2003-03-27 20:32               ` Jan Dittmer
2003-03-27 21:53                 ` Greg KH
2003-03-27 22:23                   ` Mark M. Hoffman
2003-03-28  6:05                   ` Martin Schlemmer
2003-03-28 18:34             ` Pavel Machek
2003-03-26 20:29     ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Greg KH
2003-03-26 23:34       ` Martin Schlemmer
2003-03-26 23:46         ` Greg KH
2003-03-30 12:47           ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs support, empty tree) Martin Schlemmer
2003-04-02 22:22             ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2003-03-27 23:00 lm sensors sysfs file structure Albert Cahalan
2003-03-27 23:10 ` Greg KH
2003-03-28  7:21   ` Martin Schlemmer
2003-03-28  7:40     ` Greg KH
2003-04-03 21:19 Grover, Andrew
2003-04-14 15:16 ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030331224439.A7000@kroah.com \
    --to=greg@kroah.com \
    --cc=azarah@gentoo.org \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=mds@paradyne.com \
    --cc=pavel@ucw.cz \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox