From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.66] sychronize_net patch (1/2)
Date: Tue, 01 Apr 2003 09:51:53 -0800 (PST) [thread overview]
Message-ID: <20030401.095153.92005641.davem@redhat.com> (raw)
In-Reply-To: <1049152378.2204.22.camel@dell_ss3.pdx.osdl.net>
From: Stephen Hemminger <shemminger@osdl.org>
Date: 31 Mar 2003 15:12:58 -0800
@@ -2508,6 +2508,12 @@
return 0;
}
+/* Synchronize with packet receive processing. */
+void synchronize_net() {
+ br_write_lock_bh(BR_NETPROTO_LOCK);
+ br_write_unlock_bh(BR_NETPROTO_LOCK);
+}
+
Functions without arguments are specified with "(void)" not "()", I'm
surprised the compiler didn't warn you about this.
Also, bad code style:
void function_name(args)
{
}
Never like:
void function_name(args) {
}
Functions are not braced like conditional statements such as:
if (foo) {
}
or
while (foo) {
}
Please fix this stuff.
next prev parent reply other threads:[~2003-04-01 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-31 23:12 [PATCH 2.5.66] sychronize_net patch (1/2) Stephen Hemminger
2003-04-01 17:51 ` David S. Miller [this message]
2003-04-01 19:20 ` Stephen Hemminger
2003-04-03 12:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030401.095153.92005641.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox