acpi spinlock breakage

acpi spinlock breakage

[Dave Jones]

osl stuff looks really borked in current 2.5-bk ..

drivers/acpi/osl.c: In function `acpi_os_acquire_lock':
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `magic' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `lock' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `babble' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `module' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `owner' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `oline' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `babble' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `lock' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `owner' in something not a structure or union
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `oline' in something not a structure or union
drivers/acpi/osl.c: In function `acpi_os_release_lock':
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `magic' in something not a structure or union
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `lock' in something not a structure or union
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `babble' in something not a structure or union
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `module' in something not a structure or union
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `babble' in something not a structure or union
drivers/acpi/osl.c:758: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:758: request for member `lock' in something not a structure or union
make[2]: *** [drivers/acpi/osl.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2

Looks like its trying to spin_lock an 'acpi_handle',
which is typedef'd to void *

		Dave

Re: acpi spinlock breakage

[Shawn Starr]

Confirmed :-(

Trying to find out what broke, but none of those members are listed even 
inside osl.c (perhaps a header down the line).

>List:     linux-kernel
>Subject:  acpi spinlock breakage
From:     Dave Jones <davej () codemonkey ! org ! uk>
>Date:     2003-04-02 16:21:26

>osl stuff looks really borked in current 2.5-bk ..

>drivers/acpi/osl.c: In function `acpi_os_acquire_lock':
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `magic' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `lock' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `babble' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `module' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `owner' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `oline' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `babble' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `lock' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `owner' in something not a 
>structure or union
>drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
>drivers/acpi/osl.c:739: request for member `oline' in something not a 
>structure or union
>...

-- 
Shawn Starr
UNIX Systems Administrator, Operations
Datawire Communication Networks Inc.
10 Carlson Court, Suite 300
Toronto, ON, M9W 6L2
T: 416-213-2001 ext 179  F: 416-213-2008
shawn.starr@datawire.net
"The power to Transact" - http://www.datawire.net

Re: acpi spinlock breakage

[Dave Jones]

On Thu, Apr 03, 2003 at 12:26:12PM -0500, Shawn Starr wrote:
 > Confirmed :-(
 > 
 > Trying to find out what broke, but none of those members are listed even 
 > inside osl.c (perhaps a header down the line).

They're members of the spinlock_t struct.
That acpi_handle needs to be a spinlock_t *

		Dave