[patch] add i2c_clientname()

[patch] add i2c_clientname()

[Gerd Knorr]

  Hi,

This patch just adds a #define and a inline function to hide the
"i2c_client->name" => "i2c_client->dev.name" move introduced by
the recent i2c updates.  That makes it easier to build i2c drivers
on both 2.4 and 2.5 kernels.

  Gerd

diff -u linux-2.5.66/include/linux/i2c.h linux/include/linux/i2c.h
--- linux-2.5.66/include/linux/i2c.h	2003-04-02 11:42:19.455041606 +0200
+++ linux/include/linux/i2c.h	2003-04-02 11:49:36.479533709 +0200
@@ -182,6 +182,13 @@
 	return dev_set_drvdata (&dev->dev, data);
 }
 
+#define I2C_DEVNAME(str)   .dev = { .name = str }
+
+static inline char *i2c_clientname(struct i2c_client *c)
+{
+	return c->dev.name;
+}
+
 /*
  * The following structs are for those who like to implement new bus drivers:
  * i2c_algorithm is the interface to a class of hardware solutions which can

-- 
Michael Moore for president!

Re: [patch] add i2c_clientname()

[Greg KH]

On Wed, Apr 02, 2003 at 06:51:16PM +0200, Gerd Knorr wrote:
> 
> This patch just adds a #define and a inline function to hide the
> "i2c_client->name" => "i2c_client->dev.name" move introduced by
> the recent i2c updates.  That makes it easier to build i2c drivers
> on both 2.4 and 2.5 kernels.

This is going to be a harder and harder problem as time goes on, and as
the i2c core changes over time.  I would just give up now :)

> +#define I2C_DEVNAME(str)   .dev = { .name = str }

Why this macro?  You don't use it in your driver, right?

thanks,

greg k-h

Re: [patch] add i2c_clientname()

[Gerd Knorr]

> > This patch just adds a #define and a inline function to hide the
> > "i2c_client->name" => "i2c_client->dev.name" move introduced by
> > the recent i2c updates.  That makes it easier to build i2c drivers
> > on both 2.4 and 2.5 kernels.
> 
> This is going to be a harder and harder problem as time goes on, and as
> the i2c core changes over time.  I would just give up now :)

I don't, interfacing with the i2c core is not that much code in most
drivers.

> > +#define I2C_DEVNAME(str)   .dev = { .name = str }
> 
> Why this macro?  You don't use it in your driver, right?

I use it in my current driver code (patches are at
http://bytesex.org/patches/wip/).  Submitting those patches doesn't
make sense before that patch is in because I would get flooded with
"bttv doesn't compile any more" style mails ...

  Gerd

-- 
Michael Moore for president!

Re: [patch] add i2c_clientname()

[Greg KH]

On Wed, Apr 02, 2003 at 06:51:16PM +0200, Gerd Knorr wrote:
>   Hi,
> 
> This patch just adds a #define and a inline function to hide the
> "i2c_client->name" => "i2c_client->dev.name" move introduced by
> the recent i2c updates.  That makes it easier to build i2c drivers
> on both 2.4 and 2.5 kernels.

Thanks, I've applied this patch and will send it on soon.

greg k-h