From: Anton Blanchard <anton@samba.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: riel@redhat.com, linux-kernel@vger.kernel.org, linux390@de.ibm.com
Subject: Re: gcc-3.2 breaks rmap on s390x
Date: Fri, 4 Apr 2003 05:17:50 +1000 [thread overview]
Message-ID: <20030403191750.GE27733@krispykreme> (raw)
In-Reply-To: <20030403131054.B25676@devserv.devel.redhat.com>
> the following patch seems to fix my rmap problems on s390x.
>
> --- linux-2.4.20-2.1.24.z1/include/linux/mm.h 2003-03-27 21:30:09.000000000 -0500
> +++ linux-2.4.20-2.1.24.z2/include/linux/mm.h 2003-04-02 20:26:11.000000000 -0500
> @@ -376,8 +376,10 @@
> */
> #ifdef CONFIG_SMP
> while (test_and_set_bit(PG_chainlock, &page->flags)) {
> - while (test_bit(PG_chainlock, &page->flags))
> + while (test_bit(PG_chainlock, &page->flags)) {
> cpu_relax();
> + barrier();
> + }
> }
> #endif
> }
cpu_relax() should be a gcc barrier. Its this way on all architectures in
2.5.
Anton
next prev parent reply other threads:[~2003-04-03 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 18:10 gcc-3.2 breaks rmap on s390x Pete Zaitcev
2003-04-03 18:44 ` Rik van Riel
2003-04-03 19:00 ` Davide Libenzi
2003-04-03 19:01 ` Hugh Dickins
2003-04-03 19:30 ` Pete Zaitcev
2003-04-03 19:17 ` Anton Blanchard [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-04-03 19:42 Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030403191750.GE27733@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=riel@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox