[PATCH] Keep de2104x quiet

[PATCH] Keep de2104x quiet

[Marc Zyngier]

Jeff,

The included patch tries to keep the de2104x driver quiet if there is
link change. Without this patch, I'm getting lots of :

eth0: link up, media 10baseT-HD
eth0: link up, media 10baseT-HD
eth0: link up, media 10baseT-HD

about one a minute... Quite annoying. With this patch, the driver only
logs when state changes (which is already taken care of in
de_link_up()).

Tested on an AlphaStation-500 (21040, UP).

Thanks,

        M.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1004  -> 1.1005 
#	drivers/net/tulip/de2104x.c	1.15    -> 1.16   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/04/04	maz@hina.wild-wind.fr.eu.org	1.1005
# Keep the de2104x driver quiet if link stays up.
# --------------------------------------------
#
diff -Nru a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
--- a/drivers/net/tulip/de2104x.c	Fri Apr  4 19:56:27 2003
+++ b/drivers/net/tulip/de2104x.c	Fri Apr  4 19:56:27 2003
@@ -984,11 +984,7 @@
 		add_timer(&de->media_timer);
 		if (!netif_carrier_ok(dev))
 			de_link_up(de);
-		else
-			if (netif_msg_timer(de))
-				printk(KERN_INFO "%s: %s link ok, status %x\n",
-				       dev->name, media_name[de->media_type],
-				       status);
+		
 		return;
 	}
 

-- 
Places change, faces change. Life is so very strange.

Re: [PATCH] Keep de2104x quiet

[Jeff Garzik]

On Fri, Apr 04, 2003 at 08:01:53PM +0200, Marc Zyngier wrote:
> Jeff,
> 
> The included patch tries to keep the de2104x driver quiet if there is
> link change. Without this patch, I'm getting lots of :
> 
> eth0: link up, media 10baseT-HD
> eth0: link up, media 10baseT-HD
> eth0: link up, media 10baseT-HD
> 
> about one a minute... Quite annoying. With this patch, the driver only
> logs when state changes (which is already taken care of in
> de_link_up()).

Note the netif_msg_timer() test.  Just remove that bit from the
default message bit settings.

	Jeff

Re: [PATCH] Keep de2104x quiet

[Marc Zyngier]

>>>>> "Jeff" == Jeff Garzik <jgarzik@pobox.com> writes:

Jeff> Note the netif_msg_timer() test.  Just remove that bit from the
Jeff> default message bit settings.

Ok. Neat... :-)

Would you take that patch instead ?

        M.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1004  -> 1.1005 
#	drivers/net/tulip/de2104x.c	1.15    -> 1.16   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/04/04	maz@hina.wild-wind.fr.eu.org	1.1005
# Keep the de2104x timer quiet...
# --------------------------------------------
#
diff -Nru a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
--- a/drivers/net/tulip/de2104x.c	Fri Apr  4 20:40:23 2003
+++ b/drivers/net/tulip/de2104x.c	Fri Apr  4 20:40:23 2003
@@ -77,7 +77,6 @@
 #define DE_DEF_MSG_ENABLE	(NETIF_MSG_DRV		| \
 				 NETIF_MSG_PROBE 	| \
 				 NETIF_MSG_LINK		| \
-				 NETIF_MSG_TIMER	| \
 				 NETIF_MSG_IFDOWN	| \
 				 NETIF_MSG_IFUP		| \
 				 NETIF_MSG_RX_ERR	| \

-- 
Places change, faces change. Life is so very strange.