Re: Error whilst running "tune2fs -j"

[Andrew Morton <akpm@digeo.com>]

"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> > Can you reproduce it?
> 
> Not easily, I fear ... since it's a pain in the butt to remove an ext3
> journal on the root fs once mounted. I suppose I could boot from CD
> or something ... will try to recreate on a less valuable box over
> the weekend ;-)
> 
> I had been having some other trouble with the fs (power cycled a couple
> of times for silly reasons), but it had just ext2 fscked. I suppose there
> *might* have been some corruption, but seems unlikely.
> 

OK.  Please add the below to your patchset.  I've had this in -mm for *ages*,
precisely because this problem was reported a single time, maybe four months
ago.

I have not had a report of it triggering since then.  I'd like to know what
block number it was.

diff -puN fs/buffer.c~buffer-debug fs/buffer.c
--- 25/fs/buffer.c~buffer-debug	2003-04-02 22:24:27.000000000 -0800
+++ 25-akpm/fs/buffer.c	2003-04-02 22:24:27.000000000 -0800
@@ -397,6 +397,9 @@ __find_get_block_slow(struct block_devic
 		bh = bh->b_this_page;
 	} while (bh != head);
 	buffer_error();
+	printk("block=%llu, b_blocknr=%llu\n",
+		(unsigned long long)block, (unsigned long long)bh->b_blocknr);
+	printk("b_state=0x%08lx, b_size=%u\n", bh->b_state, bh->b_size);
 out_unlock:
 	spin_unlock(&bd_mapping->private_lock);
 	page_cache_release(page);

_