2.5.66: The I2C code ate my grandma...

2.5.66: The I2C code ate my grandma...

[CaT]

...and she still can't stop grinning. 

Basically I've tracked down the poweroffs on my system using the stock
kernel. I'm now running what is basically a slightly reduced config
whose only real difference with the crashing one (that I build along the
way - 20 kernels in total) was the i2c code.

The majorly big email I sent describing exactly what happens is here:

http://marc.theaimsgroup.com/?l=linux-kernel&m=104860726612212&w=2

I2C components that were compiled in:

-CONFIG_I2C=y
-CONFIG_I2C_CHARDEV=y
-CONFIG_I2C_PIIX4=y
-CONFIG_I2C_PROC=y
-CONFIG_SENSORS_ADM1021=y

Please help. I like knowing what temp my cpu is at. :)

-- 
"Other countries of course, bear the same risk. But there's no doubt his
hatred is mainly directed at us. After all this is the guy who tried to
kill my dad."
        - George W. Bush Jr, Leader of the United States Regime
          September 26, 2002 (from a political fundraiser in Houston, Texas)

Re: 2.5.66: The I2C code ate my grandma...

[Greg KH]

On Fri, Apr 04, 2003 at 12:11:52PM +1000, CaT wrote:
> 
> I2C components that were compiled in:
> 
> -CONFIG_I2C=y
> -CONFIG_I2C_CHARDEV=y
> -CONFIG_I2C_PIIX4=y
> -CONFIG_I2C_PROC=y
> -CONFIG_SENSORS_ADM1021=y
> 
> Please help. I like knowing what temp my cpu is at. :)

So if you disable the I2C config items, everything works just fine?

I did send out a bugfix for the i2c code for a problem in 2.5.66, it's
now included in the latest -bk tree.  Could you grab that patch and see
if it fixes your problem?

thanks,

greg k-h

Re: 2.5.66: The I2C code ate my grandma...

[CaT]

On Fri, Apr 04, 2003 at 09:14:24AM -0800, Greg KH wrote:
> So if you disable the I2C config items, everything works just fine?

Yup.

> I did send out a bugfix for the i2c code for a problem in 2.5.66, it's
> now included in the latest -bk tree.  Could you grab that patch and see
> if it fixes your problem?

Ok. Running -bk10. Where, umm, is the userspace interface to it? I can't
find anything in /proc or /sys so I can't see if it's actually working.
Incase they're useful here are snippets from .config and dmesg:
 
 # I2C support
 CONFIG_I2C=y
 # CONFIG_I2C_ALGOBIT is not set
 # CONFIG_I2C_ALGOPCF is not set
 CONFIG_I2C_CHARDEV=y
 # I2C Hardware Sensors Mainboard support
 # CONFIG_I2C_ALI15X3 is not set
 # CONFIG_I2C_AMD756 is not set
 # CONFIG_I2C_AMD8111 is not set
 # CONFIG_I2C_I801 is not set
 CONFIG_I2C_PIIX4=y
 # I2C Hardware Sensors Chip support
 CONFIG_SENSORS_ADM1021=y
 # CONFIG_SENSORS_LM75 is not set
 # CONFIG_SENSORS_VIA686A is not set
 # CONFIG_SENSORS_W83781D is not set
 CONFIG_I2C_SENSOR=y

i2c-dev.o: i2c /dev entries driver module version 2.7.0 (20021208)
i2c-piix4 version 2.7.0 (20021208)
piix4 smbus 00:07.3: Found Intel Corp. 82371AB/EB/MB PIIX4  device
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
i2c i2c-0: Error: no response!
registering 0-004d
i2c i2c-0: Error: no response!

One question. Will I need ISA support in the kernel for this?

-- 
Martin's distress was in contrast to the bitter satisfaction of some
of his fellow marines as they surveyed the scene. "The Iraqis are sick
people and we are the chemotherapy," said Corporal Ryan Dupre. "I am
starting to hate this country. Wait till I get hold of a friggin' Iraqi.
No, I won't get hold of one. I'll just kill him."
	- http://www.informationclearinghouse.info/article2479.htm

Re: 2.5.66: The I2C code ate my grandma...

[Greg KH]

On Sat, Apr 05, 2003 at 10:59:50AM +1000, CaT wrote:
> On Fri, Apr 04, 2003 at 09:14:24AM -0800, Greg KH wrote:
> > So if you disable the I2C config items, everything works just fine?
> 
> Yup.
> 
> > I did send out a bugfix for the i2c code for a problem in 2.5.66, it's
> > now included in the latest -bk tree.  Could you grab that patch and see
> > if it fixes your problem?
> 
> Ok. Running -bk10. Where, umm, is the userspace interface to it? I can't
> find anything in /proc or /sys so I can't see if it's actually working.
> Incase they're useful here are snippets from .config and dmesg:

To a:
	tree /sys/bus/i2c/devices/
to see all of the i2c devices in your system.
Then go in to the directories of those devices to see the sensor values
for the devices.

libsensor support will be forthcoming soon for these changes.

> One question. Will I need ISA support in the kernel for this?

Depends, did you need it before?  :)
I didn't change any of that logic, just where the information the
sensors report has moved locations.

thanks,

greg k-h

Re: 2.5.66: The I2C code ate my grandma...

[CaT]

On Fri, Apr 04, 2003 at 05:14:14PM -0800, Greg KH wrote:
> To a:
> 	tree /sys/bus/i2c/devices/
> to see all of the i2c devices in your system.
> Then go in to the directories of those devices to see the sensor values
> for the devices.

AHA! I was sure I ran find /sys -name '*i2c*'. hrrumph.

> libsensor support will be forthcoming soon for these changes.

Cool. I'll just modify my little script for now. :)

> > One question. Will I need ISA support in the kernel for this?
> 
> Depends, did you need it before?  :)

No. But it made me wonder. :)

> I didn't change any of that logic, just where the information the
> sensors report has moved locations.

Well so far so good. Haven't stressed it yet. Wanted to see that i2c was
actually functioning first. :)

-- 
Martin's distress was in contrast to the bitter satisfaction of some
of his fellow marines as they surveyed the scene. "The Iraqis are sick
people and we are the chemotherapy," said Corporal Ryan Dupre. "I am
starting to hate this country. Wait till I get hold of a friggin' Iraqi.
No, I won't get hold of one. I'll just kill him."
	- http://www.informationclearinghouse.info/article2479.htm

Re: 2.5.66: The I2C code ate my grandma...

[Greg KH]

On Sat, Apr 05, 2003 at 11:16:07AM +1000, CaT wrote:
> On Fri, Apr 04, 2003 at 05:14:14PM -0800, Greg KH wrote:
> > To a:
> > 	tree /sys/bus/i2c/devices/
> > to see all of the i2c devices in your system.
> > Then go in to the directories of those devices to see the sensor values
> > for the devices.
> 
> AHA! I was sure I ran find /sys -name '*i2c*'. hrrumph.
> 
> > libsensor support will be forthcoming soon for these changes.
> 
> Cool. I'll just modify my little script for now. :)

Great.  Can you validate that the output of the sysfs files is in the
proper units (should be milliVolts and milliCelcius)?  I am pretty sure
I got this one wrong, as I don't have the hardware to test it on.

thanks,

greg k-h

Re: 2.5.66: The I2C code ate my grandma...

[CaT]

On Fri, Apr 04, 2003 at 05:24:14PM -0800, Greg KH wrote:
> > Cool. I'll just modify my little script for now. :)
> 
> Great.  Can you validate that the output of the sysfs files is in the
> proper units (should be milliVolts and milliCelcius)?  I am pretty sure
> I got this one wrong, as I don't have the hardware to test it on.

I don't think I saw any. From memory there was temp info, power, on_die
and one or two other things (alarm maybe). This is from memory thoguh as
the kernel died during my compiling the kernel, mplayer and using
mozilla. Symptoms as before.

Current -bk10 kernel servived that.  Differences are:

+CONFIG_I2C=y
+CONFIG_I2C_CHARDEV=y
+CONFIG_I2C_PIIX4=y
+CONFIG_SENSORS_ADM1021=y
+CONFIG_I2C_SENSOR=y

-- 
Martin's distress was in contrast to the bitter satisfaction of some
of his fellow marines as they surveyed the scene. "The Iraqis are sick
people and we are the chemotherapy," said Corporal Ryan Dupre. "I am
starting to hate this country. Wait till I get hold of a friggin' Iraqi.
No, I won't get hold of one. I'll just kill him."
	- http://www.informationclearinghouse.info/article2479.htm