public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jerome Chantelauze <jchantelauze@free.fr>
To: linux-kernel@vger.kernel.org
Subject: [Patch 2.4.21-pre7] Old hard disk (MFM/RLL/IDE) driver not build.
Date: Sun, 6 Apr 2003 17:25:11 +0200	[thread overview]
Message-ID: <20030406152511.GA248@i486X33> (raw)

Hi.

I applied Stephane Ouellette's patch on my linux 2.4.21-pre7. Now, the
kernel builds.

But, there's a problem with the IDE support (problem also present in
2.4.21-pre6, but not in 2.4.20).

I configure the kernel to use the "Old hard disk (MFM/RLL/IDE)" driver:

#
# IDE, ATA and ATAPI Block devices
#
# CONFIG_BLK_DEV_IDE is not set
CONFIG_BLK_DEV_HD_ONLY=y
CONFIG_BLK_DEV_HD=y
...

drivers/ide/Makefile does not compile the drivers/ide/legacy/ subdir and
generates an empty idedriver.o because CONFIG_BLK_DEV_IDE is not set.
Setting this option would result in a driver not compatible with my old
hardware.

The following patch fixes the problem, but is it ok ?

*** linux-2.4.21-pre7/drivers/ide/Makefile.orig Sat Apr  5 18:57:07 2003
--- linux-2.4.21-pre7/drivers/ide/Makefile      Sat Apr  5 19:16:48 2003
***************
*** 21,26 ****
--- 21,28 ----

  subdir-$(CONFIG_BLK_DEV_IDE) += legacy ppc arm raid pci

+ subdir-$(CONFIG_BLK_DEV_HD_ONLY) += legacy
+
  # First come modules that register themselves with the core

  ifeq ($(CONFIG_BLK_DEV_IDE),y)
***************
*** 48,53 ****
--- 50,59 ----
    obj-y               += legacy/idedriver-legacy.o
    obj-y               += ppc/idedriver-ppc.o
    obj-y               += arm/idedriver-arm.o
+ endif
+
+ ifeq ($(CONFIG_BLK_DEV_HD_ONLY),y)
+   obj-y               += legacy/idedriver-legacy.o
  endif

  ifeq ($(CONFIG_BLK_DEV_IDE),y)


Regards.
--
Jerome Chantelauze.

                 reply	other threads:[~2003-04-06 15:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030406152511.GA248@i486X33 \
    --to=jchantelauze@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox