[PATCH] remove kdevname() before someone starts using it again

[PATCH] remove kdevname() before someone starts using it again

[Christoph Hellwig]

--- 1.14/fs/libfs.c	Wed Jan  1 02:18:35 2003
+++ edited/fs/libfs.c	Wed Mar 26 21:32:02 2003
@@ -332,14 +332,3 @@
 	set_page_dirty(page);
 	return 0;
 }
-
-/*
- * Print device name (in decimal, hexadecimal or symbolic)
- * Note: returns pointer to static data!
- */
-const char * kdevname(kdev_t dev)
-{
-	static char buffer[32];
-	sprintf(buffer, "%02x:%02x", major(dev), minor(dev));
-	return buffer;
-}
--- 1.222/include/linux/fs.h	Sun Mar 23 07:14:19 2003
+++ edited/include/linux/fs.h	Wed Mar 26 21:32:08 2003
@@ -1074,7 +1074,6 @@
 extern void close_bdev_excl(struct block_device *, int);
 
 extern const char * cdevname(kdev_t);
-extern const char * kdevname(kdev_t);
 extern void init_special_inode(struct inode *, umode_t, dev_t);
 
 /* Invalid inode operations -- fs/bad_inode.c */
--- 1.7/include/linux/kdev_t.h	Fri Nov  1 13:28:19 2002
+++ edited/include/linux/kdev_t.h	Wed Mar 26 21:32:14 2003
@@ -101,8 +101,6 @@
 #define NODEV		(mk_kdev(0,0))
 #define B_FREE		(mk_kdev(0xff,0xff))
 
-extern const char * kdevname(kdev_t);	/* note: returns pointer to static data! */
-
 static inline int kdev_same(kdev_t dev1, kdev_t dev2)
 {
 	return dev1.value == dev2.value;
--- 1.186/kernel/ksyms.c	Sat Mar 22 05:05:21 2003
+++ edited/kernel/ksyms.c	Wed Mar 26 21:32:22 2003
@@ -511,7 +511,6 @@
 EXPORT_SYMBOL(vsprintf);
 EXPORT_SYMBOL(vsnprintf);
 EXPORT_SYMBOL(vsscanf);
-EXPORT_SYMBOL(kdevname);
 EXPORT_SYMBOL(__bdevname);
 EXPORT_SYMBOL(cdevname);
 EXPORT_SYMBOL(simple_strtoull);

Re: [PATCH] remove kdevname() before someone starts using it again

[Nicholas Wourms]

Christoph Hellwig wrote:
> --- 1.14/fs/libfs.c	Wed Jan  1 02:18:35 2003
> +++ edited/fs/libfs.c	Wed Mar 26 21:32:02 2003
> @@ -332,14 +332,3 @@
>  	set_page_dirty(page);
>  	return 0;

A quick grep shows that Intermezzo FS still uses kdevname if 
you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
pending stuff, both Reiser4 & pktcdvd also use it.  So I 
guess people are still using it...  What is your reason for 
removing it?

Cheers,
Nicholas

Re: [PATCH] remove kdevname() before someone starts using it again

[Christoph Hellwig]

On Sun, Apr 06, 2003 at 04:28:38PM -0400, Nicholas Wourms wrote:
> Christoph Hellwig wrote:
> > --- 1.14/fs/libfs.c	Wed Jan  1 02:18:35 2003
> > +++ edited/fs/libfs.c	Wed Mar 26 21:32:02 2003
> > @@ -332,14 +332,3 @@
> >  	set_page_dirty(page);
> >  	return 0;
> 
> A quick grep shows that Intermezzo FS still uses kdevname if 
> you've turned on debugging (fs/intermezzo/sysctl.c).

Look at the code.  It's not compiled in, and if someone sets the
cpp macro it won't build for lots of other reasons (e.g. set_device_ro
prototype).

> As for 
> pending stuff, both Reiser4 & pktcdvd also use it.  So I 
> guess people are still using it...

That's they problem.  Bot that either of them is scheduled for 2.6
anyway as far as I know.

> What is your reason for 
> removing it?

It's a broken interface.  Use the proper replacements instead.

Re: [PATCH] remove kdevname() before someone starts using it again

[Nikita Danilov]

Nicholas Wourms writes:
 > 
 > A quick grep shows that Intermezzo FS still uses kdevname if 
 > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
 > pending stuff, both Reiser4 & pktcdvd also use it.  So I 

reiser4 switched to bdevname().

 > guess people are still using it...  What is your reason for 
 > removing it?
 > 
 > Cheers,
 > Nicholas

Nikita.

Re: [PATCH] remove kdevname() before someone starts using it again

[Christoph Hellwig]

On Mon, Apr 07, 2003 at 11:43:01AM +0400, Nikita Danilov wrote:
> Nicholas Wourms writes:
>  > 
>  > A quick grep shows that Intermezzo FS still uses kdevname if 
>  > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
>  > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
> 
> reiser4 switched to bdevname().

Although bdevname is the simplest replacement it's usually the wrong
one.  If you refer to a filesystem with it use sb->s_id, if you refer
to a block device you normally want to use partition_name() - it gives
much nicer output.

Re: [PATCH] remove kdevname() before someone starts using it again

[Andrew Morton]

Christoph Hellwig <hch@infradead.org> wrote:
>
> partition_name()

That function would appear to be

a) slow

b) leaky

c) racy and

d) plain wrong if dev_t's can get recycled.

Can we at least give it a lock? :(

Re: [PATCH] remove kdevname() before someone starts using it again

[Nikita Danilov]

Christoph Hellwig writes:
 > On Mon, Apr 07, 2003 at 11:43:01AM +0400, Nikita Danilov wrote:
 > > Nicholas Wourms writes:
 > >  > 
 > >  > A quick grep shows that Intermezzo FS still uses kdevname if 
 > >  > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
 > >  > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
 > > 
 > > reiser4 switched to bdevname().
 > 
 > Although bdevname is the simplest replacement it's usually the wrong
 > one.  If you refer to a filesystem with it use sb->s_id, if you refer
 > to a block device you normally want to use partition_name() - it gives
 > much nicer output.

Thank you for the information.

We need something to name per super block directory under
/sys/fs/reiser4. It probably makes sense to have a convention for this
shared by all file systems living on top of block devices, like using
sb->s_id.

 > 

Nikita.

Re: [PATCH] remove kdevname() before someone starts using it again

[Nicholas Wourms]

Nikita Danilov wrote:
> Nicholas Wourms writes:
>  > 
>  > A quick grep shows that Intermezzo FS still uses kdevname if 
>  > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
>  > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
> 
> reiser4 switched to bdevname().
> 

When will the reiser4 bk repo be updated to reflect this? 
It has been pretty quiet for the last few days or so, 
compared to the daily updating it used to get.  As of 
yesterday, trying to compile reiser4 as a module yeilded the 
undefined reference to kdevname in a few places, not to 
mention a few other undefined references as well...

Cheers,
Nicholas

Re: [PATCH] remove kdevname() before someone starts using it again

[Nikita Danilov]

Nicholas Wourms writes:
 > Nikita Danilov wrote:
 > > Nicholas Wourms writes:
 > >  > 
 > >  > A quick grep shows that Intermezzo FS still uses kdevname if 
 > >  > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
 > >  > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
 > > 
 > > reiser4 switched to bdevname().
 > > 
 > 
 > When will the reiser4 bk repo be updated to reflect this? 
 > It has been pretty quiet for the last few days or so, 
 > compared to the daily updating it used to get.  As of 

It is currently undergoing some changing that rendered it unstable. I
hope in few days a lot of commits will be made.

 > yesterday, trying to compile reiser4 as a module yeilded the 
 > undefined reference to kdevname in a few places, not to 
 > mention a few other undefined references as well...

We are not paying attention to the compilability as module yet.  
Apropos, thank you for trying reiser4.

 > 
 > Cheers,
 > Nicholas
 > 

Nikita.

Re: [PATCH] remove kdevname() before someone starts using it again

[Nicholas Wourms]

Nikita Danilov wrote:
> Nicholas Wourms writes:
>  > Nikita Danilov wrote:
>  > > Nicholas Wourms writes:
>  > >  > 
>  > >  > A quick grep shows that Intermezzo FS still uses kdevname if 
>  > >  > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
>  > >  > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
>  > > 
>  > > reiser4 switched to bdevname().
>  > > 
>  > 
>  > When will the reiser4 bk repo be updated to reflect this? 
>  > It has been pretty quiet for the last few days or so, 
>  > compared to the daily updating it used to get.  As of 
> 
> It is currently undergoing some changing that rendered it unstable. I
> hope in few days a lot of commits will be made.
> 
>  > yesterday, trying to compile reiser4 as a module yeilded the 
>  > undefined reference to kdevname in a few places, not to 
>  > mention a few other undefined references as well...
> 
> We are not paying attention to the compilability as module yet.  
> Apropos, thank you for trying reiser4.
> 

No problem.  I can send you a patch against the 
reiser4-linux-2.5 tree which contains the relevant exports 
needed to compile reiser4 as a module.  Though, I haven't 
actually been able to test reiser as a module since the 
recent 2.5 is causing some major headaches in other areas :-).

Cheers,
Nicholas

Re: [PATCH] remove kdevname() before someone starts using it again

[Oleg Drokin]

Hello!

On Mon, Apr 07, 2003 at 10:08:58AM -0400, Nicholas Wourms wrote:
> > > A quick grep shows that Intermezzo FS still uses kdevname if 
> > > you've turned on debugging (fs/intermezzo/sysctl.c).  As for 
> > > pending stuff, both Reiser4 & pktcdvd also use it.  So I 
> >reiser4 switched to bdevname().
> When will the reiser4 bk repo be updated to reflect this? 
> It has been pretty quiet for the last few days or so, 
> compared to the daily updating it used to get.  As of 
> yesterday, trying to compile reiser4 as a module yeilded the 
> undefined reference to kdevname in a few places, not to 
> mention a few other undefined references as well...

Ah, our private bk repo -> public bk repo have died for some reason.
I restarted it. All the recent changes should appear soon.

Bye,
    Oleg

Re: [PATCH] remove kdevname() before someone starts using it again

[Oleg Drokin]

Hello!

On Mon, Apr 07, 2003 at 10:35:58AM -0400, Nicholas Wourms wrote:

> No problem.  I can send you a patch against the 
> reiser4-linux-2.5 tree which contains the relevant exports 
> needed to compile reiser4 as a module.  Though, I haven't 

Please send it. Thank you.

Bye,
    Oleg