public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Martin Schlemmer <azarah@gentoo.org>
Cc: KML <linux-kernel@vger.kernel.org>, sensors@Stimpy.netroedge.com
Subject: Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs
Date: Mon, 7 Apr 2003 14:54:43 -0700	[thread overview]
Message-ID: <20030407215443.GA4386@kroah.com> (raw)
In-Reply-To: <1049750163.4174.35.camel@nosferatu.lan>

On Mon, Apr 07, 2003 at 11:16:03PM +0200, Martin Schlemmer wrote:
> --- drivers/i2c/chips/w83781d.c.orig	2003-04-07 22:53:37.000000000 +0200
> +++ drivers/i2c/chips/w83781d.c	2003-04-07 22:53:34.000000000 +0200
> @@ -364,7 +364,7 @@
>  	 \
>  	w83781d_update_client(client); \
>  	 \
> -	return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr] * 10)); \
> +	return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr])); \

Hm, this patch looks backwards, is it?

Also, just as a side note, can you make your patches so that they can be
applied with "patch -p1" instead of "patch -p0" which your current ones
are?  My tools treat -p1 patches much better :)

thanks,

greg k-h

  reply	other threads:[~2003-04-07 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-07 21:16 [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs Martin Schlemmer
2003-04-07 21:54 ` Greg KH [this message]
2003-04-08  4:11   ` Martin Schlemmer
2003-04-08 22:04     ` Greg KH
2003-04-09  6:18       ` Martin Schlemmer
2003-04-09  7:41         ` Greg KH
2003-04-08 22:11   ` Martin Schlemmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030407215443.GA4386@kroah.com \
    --to=greg@kroah.com \
    --cc=azarah@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox