Re: 2.5.67-mm1

[Badari Pulavarty <pbadari@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On Tuesday 08 April 2003 02:28 pm, Andrew Morton wrote:
> Alistair Strachan <alistair@devzero.co.uk> wrote:
> > On attempting to boot this kernel, I get the following just before init:
> > Kernel panic: VFS: Unable to mount root fs on 03:05
> >
> > 2.5.67 base works fine. I discovered that reverting the following
> > patches allows me to boot. I can increase the granularity of my search
> > if nothing comes immediately to mind:
> >
> > aggregated-disk-stats.patch
> > dynamic-hd_struct-allocation-fixes.patch
> > dynamic-hd_struct-allocation.patch
>
> Ah, good detective work, thanks.  It looks like the hd_struct dynamic
> allocation patch has broken devfs partition discovery somehow.

Okay !! My bad. 

Here is the patch for 2.5.67-mm1. Could you try and let me know ?

Thanks,
Badari


[-- Attachment #2: devfs.patch --]
[-- Type: text/x-diff, Size: 1098 bytes --]

--- linux-2.5.67/fs/partitions/check.c	Tue Apr  8 16:21:30 2003
+++ linux-2.5.67.new/fs/partitions/check.c	Tue Apr  8 16:26:01 2003
@@ -163,13 +163,13 @@ static void devfs_register_partition(str
 	struct hd_struct *p = dev->part;
 	char devname[16];
 
-	if (p[part-1].de)
+	if (p[part-1]->de)
 		return;
 	dir = dev->de;
 	if (!dir)
 		return;
 	sprintf(devname, "part%d", part);
-	p[part-1].de = devfs_register (dir, devname, 0,
+	p[part-1]->de = devfs_register (dir, devname, 0,
 				    dev->major, dev->first_minor + part,
 				    S_IFBLK | S_IRUSR | S_IWUSR,
 				    dev->fops, NULL);
@@ -281,14 +281,13 @@ void add_partition(struct gendisk *disk,
 	memset(p, 0, sizeof(struct hd_struct));
 	p->start_sect = start;
 	p->nr_sects = len;
+	p->partno = part;
+	disk->part[part-1] = p;
 	devfs_register_partition(disk, part);
 	snprintf(p->kobj.name,KOBJ_NAME_LEN,"%s%d",disk->kobj.name,part);
 	p->kobj.parent = &disk->kobj;
 	p->kobj.ktype = &ktype_part;
 	kobject_register(&p->kobj);
-
-	p->partno = part;
-	disk->part[part-1] = p;
 }
 
 static void disk_sysfs_symlinks(struct gendisk *disk)