[PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Robert Schiele]

[-- Attachment #1: Type: text/plain, Size: 2397 bytes --]

Hmm, vger does not like the driver name of the Adaptec driver. ;-)

Robert

----- Forwarded message from Mail Delivery Subsystem <MAILER-DAEMON@rumms.uni-mannheim.de> -----

[...]
Final-Recipient: RFC822; linux-kernel@vger.kernel.org
Action: failed
Status: 5.7.1
Remote-MTA: DNS; vger.kernel.org
Diagnostic-Code: SMTP; 550 5.7.1 The Triple-X in subject is way too often associated with junk email, please rephrase. ; S263532AbTDHGof
Last-Attempt-Date: Tue, 8 Apr 2003 08:56:12 +0200 (MEST)

Date: Tue, 8 Apr 2003 08:55:41 +0200
To: "Justin T. Gibbs" <gibbs@scsiguy.com>,
   Marcelo Tosatti <marcelo@conectiva.com.br>,
   Linus Torvalds <torvalds@transmeta.com>,
   Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>, Kurt Garloff <garloff@suse.de>,
   Hubert Mantel <mantel@suse.de>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] aic7xxx claims all checked EISA io ranges
User-Agent: Mutt/1.4i
From: Robert Schiele <rschiele@uni-mannheim.de>

Hello.

Some days ago a bug was introduced in aic7xxx by applying the aic7xxx driver
upgrade to both the 2.4 and the 2.5 tree.  This bug makes aic7xxx to claim all
the ioport ranges that he checks while scanning for EISA cards.  Takashi Iwai
and me iterated over the sources to finally find that the result value check
of the request_region() is negated.

Because of that the following patch goes to Justin to fix it in driver
development tree, to the official tree maintainers to fix it there, and to
Alan, because you sent this driver update to Marcelo, so I assume the same
problem is in your tree.

The patch applies to both, the 2.4 and the 2.5 tree.

And now for the trivial but obvious patch:

--- linux/drivers/scsi/aic7xxx/aic7770_osm.c	1 Apr 2003 19:57:24 -0000	1.4
+++ linux/drivers/scsi/aic7xxx/aic7770_osm.c	8 Apr 2003 05:37:38 -0000
@@ -66,7 +66,7 @@
 			continue;
 		request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx");
 #else
-		if (request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx") != 0)
+		if (request_region(eisaBase, AHC_EISA_IOSIZE, "aic7xxx") == 0)
 			continue;
 #endif
 

Robert

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de




----- End forwarded message -----

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Alan Cox]

On Maw, 2003-04-08 at 21:51, Robert Schiele wrote:
> Thanks for your note.  Hope you didn't feel offended.  At least this was not
> my intention.  I just wanted to notify all people related to the affected
> driver.
> 
> So it's up to the kernel tree maintainers to bring this fix into their trees.

Maintainers submit changes to the Linux kernel tree, not vice versa. Its
push not pull

Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Justin T. Gibbs]

> Hello.
> 
> Some days ago a bug was introduced in aic7xxx by applying the aic7xxx driver
> upgrade to both the 2.4 and the 2.5 tree.

This particular defect was corrected in all versions of the aic7xxx
driver released by me after March 9th.  See the driver CHANGELOG in
the driver source distribution for details.

http://people.FreeBSD.org/~gibbs/linux/SRC/

--
Justin

Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Robert Schiele]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

On Tue, Apr 08, 2003 at 02:36:19PM -0600, Justin T. Gibbs wrote:
> > Hello.
> > 
> > Some days ago a bug was introduced in aic7xxx by applying the aic7xxx driver
> > upgrade to both the 2.4 and the 2.5 tree.
> 
> This particular defect was corrected in all versions of the aic7xxx
> driver released by me after March 9th.  See the driver CHANGELOG in
> the driver source distribution for details.
> 
> http://people.FreeBSD.org/~gibbs/linux/SRC/

Thanks for your note.  Hope you didn't feel offended.  At least this was not
my intention.  I just wanted to notify all people related to the affected
driver.

So it's up to the kernel tree maintainers to bring this fix into their trees.

Robert

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Justin T. Gibbs]

> On Maw, 2003-04-08 at 21:51, Robert Schiele wrote:
>> Thanks for your note.  Hope you didn't feel offended.  At least this was not
>> my intention.  I just wanted to notify all people related to the affected
>> driver.
>> 
>> So it's up to the kernel tree maintainers to bring this fix into their trees.
> 
> Maintainers submit changes to the Linux kernel tree, not vice versa. Its
> push not pull

As far as the 2.4.X series is concerned, pushing has not helped.  I've
seen spelling fixes and incorrorct changes get accepted from non
maintainers "instantly", while the maintainers changes are not accepted.
Considering how long it took for the last set of driver changes to make
it from -ac into kernel.org, I just assumed that this strategy was
also failing.  Is that really the only way to get updates into Marcelo's
tree?

--
Justin

Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.uni-mannheim.de: Returned mail: see transcript for details])

[Robert Schiele]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On Tue, Apr 08, 2003 at 09:18:39PM +0100, Alan Cox wrote:
> On Maw, 2003-04-08 at 21:51, Robert Schiele wrote:
> > Thanks for your note.  Hope you didn't feel offended.  At least this was not
> > my intention.  I just wanted to notify all people related to the affected
> > driver.
> > 
> > So it's up to the kernel tree maintainers to bring this fix into their trees.
> 
> Maintainers submit changes to the Linux kernel tree, not vice versa. Its
> push not pull

Well, the reason why I sent the patch to both, the maintainer of the driver
and the maintainers of the trees, is that the maintainers of the trees have
the opportunity to fix one of the more important drivers before they release a
new "official" version that is broken here, and I think that the change is
quite obvious.

To clarify this: I don't care whether and when the fix goes to the official
trees, because I have the fix for my personal kernel builds and Hubert Mantel
has it for the SuSE builds, so it Works-For-Me(TM).

Robert

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]