Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs

[Greg KH <greg@kroah.com>]

On Tue, Apr 08, 2003 at 06:11:18AM +0200, Martin Schlemmer wrote:
> On Mon, 2003-04-07 at 23:54, Greg KH wrote:
> > On Mon, Apr 07, 2003 at 11:16:03PM +0200, Martin Schlemmer wrote:
> > > --- drivers/i2c/chips/w83781d.c.orig	2003-04-07 22:53:37.000000000 +0200
> > > +++ drivers/i2c/chips/w83781d.c	2003-04-07 22:53:34.000000000 +0200
> > > @@ -364,7 +364,7 @@
> > >  	 \
> > >  	w83781d_update_client(client); \
> > >  	 \
> > > -	return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr] * 10)); \
> > > +	return sprintf(buf,"%ld\n", (long)IN_FROM_REG(data->reg[nr])); \
> > 
> > Hm, this patch looks backwards, is it?
> > 
> > Also, just as a side note, can you make your patches so that they can be
> > applied with "patch -p1" instead of "patch -p0" which your current ones
> > are?  My tools treat -p1 patches much better :)
> > 
> 
> Yes, sorry, that is reverse.  I have to go to work in a bit, so if you
> need me to resend tonight, just ask.

Thanks, I've applied this to my trees.

Oh, I'm getting the following warning when building the driver, want to
look into this?

drivers/i2c/chips/w83781d.c: In function `store_fan_div_reg':
drivers/i2c/chips/w83781d.c:715: warning: `old3' might be used uninitialized in this function
  
thanks,

greg k-h