Re: Linux 2.4.21-pre7

mikpe
2003-04-09T10:09:33Z

Benjamin Herrenschmidt writes:
> On Wed, 2003-04-09 at 11:55, mikpe@csd.uu.se wrote:
> > Kaj-Michael Lang writes:
> > > > So here goes -pre7. Hopefully the last -pre.
> > > >
> > > Won't compile for my PPC:
> > > ---
> > > -o vmlinux
> > > drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
> > > : undefined reference to `io_flush'
> > > drivers/ide/idedriver.o(.text+0x1a544): In function `pmac_outbsync':
> > > : relocation truncated to fit: R_PPC_REL24 io_flush
> >
> > Someone updated pmac.c without testing it: io_flush() doesn't exist
> > in 2.4.21-pre. Based on the diff from -pre6 to -pre7, I'd say the
> > following is a reasonable approximation. My PM4400 runs with this
> > patch right now.
>
> Or just get my devel rsync.
>
> Actually, what happened is that Marcelo took the version that was
> in -ac tree, which I sent to Alan a while ago and is now outdated.
> The io_flush macro was something I added to the arch includes and
> later removed as I fixed the problem differently.
>
> Marcelo: I sent you a fixed version, please do not apply this patch
> but rather the one I sent you.

Ok, I can understand what happened, but shouldn't these fixes be
cc:d to or at last announced on LKML as well? It could be a month
before Marcelo does a -pre8 or -rc1.