From: Greg KH <greg@kroah.com>
To: Duncan Sands <baldrick@wanadoo.fr>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware
Date: Wed, 9 Apr 2003 16:31:24 -0700 [thread overview]
Message-ID: <20030409233124.GE3203@kroah.com> (raw)
In-Reply-To: <200304091028.25268.baldrick@wanadoo.fr>
On Wed, Apr 09, 2003 at 10:28:25AM +0200, Duncan Sands wrote:
> > > Hi Greg, I'm waiting on the fixes to the ATM layer (coming soon to a
> > > kernel near you).
> >
> > Ah, ok, that makes sense.
> >
> > > As for the position of MOD_INC_USE_COUNT, did you ever hear
> > > of anyone getting bitten by a race like this? If it makes you feel
> > > better, I will move it up, probably just before I take the semaphore
> > > (since that is the first place we can sleep). I will do it tomorrow, OK?
> >
> > Yes, it needs to be before any function that can sleep. I'll hold off
> > applying this patch then.
>
> How about this one instead. MOD_INC_USE_COUNT is placed before I call
> any functions that can sleep. Let's just hope that the call to me doesn't
> come after some sleeping in the higher layers...
Much better, thanks. Applied.
greg k-h
next prev parent reply other threads:[~2003-04-09 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-08 7:26 [PATCH] USB speedtouch: don't open a connection if no firmware Duncan Sands
2003-04-08 20:12 ` [linux-usb-devel] " Greg KH
2003-04-08 20:22 ` Duncan Sands
2003-04-08 21:40 ` Greg KH
2003-04-09 8:28 ` Duncan Sands
2003-04-09 23:31 ` Greg KH [this message]
[not found] <OF50785981.C7D592CC-ON85256D02.007454B5-85256D02.007ACB50@wsib.on.ca>
2003-04-09 8:31 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030409233124.GE3203@kroah.com \
--to=greg@kroah.com \
--cc=baldrick@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox