From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262945AbTDNKPh (for ); Mon, 14 Apr 2003 06:15:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262947AbTDNKPh (for ); Mon, 14 Apr 2003 06:15:37 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:64975 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262945AbTDNKPg (for ); Mon, 14 Apr 2003 06:15:36 -0400 Date: Mon, 14 Apr 2003 12:27:23 +0200 From: Jens Axboe To: Andrew Morton Cc: alan@lxorguk.ukuu.org.uk, marcelo@conectiva.com.br, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.4.21-pre7 ide request races Message-ID: <20030414102723.GS9776@suse.de> References: <20030414093418.GQ9776@suse.de> <20030414030751.7bf17b04.akpm@digeo.com> <20030414101747.GR9776@suse.de> <20030414032339.27079dd8.akpm@digeo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030414032339.27079dd8.akpm@digeo.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 14 2003, Andrew Morton wrote: > Jens Axboe wrote: > > > > How would that solve the problem? The request could be gone even before > > end_that_request_last() is run, that is the issue. > > In that case I didn't understand your description of the bug even the tiniest > little bit. > > That request is sitting in the kernel stack of some process which is sleeping > in wait_for_completion(). Hence it is safe memory until someone runs > complete() against the completion struct. Sorry you are right, that should fix the problem as well! Your fix is probably the better one for 2.4, less intrusive. I'll kill the stack requests in 2.5 then. -- Jens Axboe