From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Russell King <rmk@arm.linux.org.uk>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew.Morton@digeo.com
Subject: Re: uart_ioctl OOPS with irtty-sir
Date: Mon, 14 Apr 2003 09:30:13 -0700 [thread overview]
Message-ID: <20030414163013.GA2402@bougret.hpl.hp.com> (raw)
In-Reply-To: <20030413170439.B855@flint.arm.linux.org.uk>
On Sun, Apr 13, 2003 at 05:04:39PM +0100, Russell King wrote:
> Jean,
>
> How about this patch - this also moves the ioctl parsing to the tty
> layer. I'm intending all drivers should provide tiocmget and tiocmset
> methods if they implement modem control lines, and not parse the
> corresponding ioctl command numbers in their ioctl method.
>
> Note - this patch has only been compile-tested except for the last file,
> and may apply with an offset(s). The irtty-sir patch is actually yours;
> I just edited your patch for that file since it was a straight forward
> change.
Looks good. I'm going to test that and report.
Thanks a lot !
Jean
next prev parent reply other threads:[~2003-04-14 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-04 1:34 uart_ioctl OOPS with irtty-sir Jean Tourrilhes
2003-04-04 9:25 ` Russell King
2003-04-04 17:24 ` Jean Tourrilhes
2003-04-08 17:44 ` Jean Tourrilhes
2003-04-13 16:04 ` Russell King
2003-04-14 16:30 ` Jean Tourrilhes [this message]
2003-04-13 16:51 ` Russell King
2003-04-14 16:31 ` Jean Tourrilhes
2003-04-10 2:29 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030414163013.GA2402@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=Andrew.Morton@digeo.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox