From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: dipankar@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] dentry_stat fix
Date: Mon, 14 Apr 2003 18:09:10 +0530 [thread overview]
Message-ID: <20030414180910.B27092@in.ibm.com> (raw)
In-Reply-To: <20030414021448.08ff05a5.akpm@digeo.com>; from akpm@digeo.com on Mon, Apr 14, 2003 at 02:14:48AM -0700
On Mon, Apr 14, 2003 at 02:14:48AM -0700, Andrew Morton wrote:
> Maneesh Soni <maneesh@in.ibm.com> wrote:
> >
> > This patch the corrects the dentry_stat.nr_unused calculation.
>
> OK, I didn't even know we had a bug in there...
>
> btw, can you explain to me why shrink_dcache_anon() and select_parent() are
> putting dentries at the wrong end of dentry_unused?
prune_dcache() picks up from this end in first round. It will reset the
DCACHE_REFERENCED flag and will put it to the front of dentry_unused list.
>
> Do these dentries have DCACHE_REFERENCED set?
They will have DCACHE_REFERENCED set as they are on the unused list. The flag
get reset in the first round of aging.
> Why shouldn't they get a full two rounds of aging?
They do get.
> It is not clear what's going on in there. Thanks.
I am posting one more patch which makes the DCACHE_REFERENCED flag uses
proper following this one.
Maneesh
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
next prev parent reply other threads:[~2003-04-14 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 9:14 [patch] dentry_stat fix Maneesh Soni
2003-04-14 9:14 ` Andrew Morton
2003-04-14 12:39 ` Maneesh Soni [this message]
2003-04-14 19:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030414180910.B27092@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=akpm@digeo.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox