public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan von Krawczynski <skraw@ithnet.com>
To: Arno Wilhelm <a.wilhelm@phion.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Kernel 2.4.20 crashes when a second isdn channel is opened by ibod
Date: Wed, 16 Apr 2003 11:33:02 +0200	[thread overview]
Message-ID: <20030416113302.1fef0dcc.skraw@ithnet.com> (raw)
In-Reply-To: <3E9D1A2D.1020109@phion.com>

This bug is known and fixed by Patrick McHardy <kaber@trash.net>.
Please use patch attached and confirm it works. Thank you.


See Changelog

On Wed, 16 Apr 2003 10:54:05 +0200
Arno Wilhelm <a.wilhelm@phion.com> wrote:

> Hello,
> 
> I guess we have detected a kernel bug in the isdn subsystem ( isdn_ppp.c ).
> I have enclosed the bug report in this mail in the format that is asked by
> the file "REPORTING-BUGS" in the kernel source directory.
> If you need further assistance please mail to: a.wilhelm@phion.com
> 
> 
> 
> Regards,
> 
> 			Arno Wilhelm

-- 
Regards,
Stephan

diff -Nru a/drivers/isdn/isdn_net.c b/drivers/isdn/isdn_net.c
--- a/drivers/isdn/isdn_net.c   Thu Mar 27 02:00:21 2003
+++ b/drivers/isdn/isdn_net.c   Thu Mar 27 02:00:21 2003
@@ -2831,6 +2831,7 @@
 
                        /* If binding is exclusive, try to grab the channel */
                        save_flags(flags);
+                       cli();
                        if ((i = isdn_get_free_channel(ISDN_USAGE_NET,
                                lp->l2_proto, lp->l3_proto, drvidx,
                                chidx, lp->msn)) < 0) {
diff -Nru a/drivers/isdn/isdn_ppp.c b/drivers/isdn/isdn_ppp.c
--- a/drivers/isdn/isdn_ppp.c   Thu Mar 27 02:00:21 2003
+++ b/drivers/isdn/isdn_ppp.c   Thu Mar 27 02:00:21 2003
@@ -1176,7 +1176,7 @@
        if (!lp) {
                printk(KERN_WARNING "%s: all channels busy - requeuing!\n", netdev->name);
                retval = 1;
-               goto unlock;
+               goto out;
        }
        /* we have our lp locked from now on */
 



  reply	other threads:[~2003-04-16  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-16  8:54 PROBLEM: Kernel 2.4.20 crashes when a second isdn channel is opened by ibod Arno Wilhelm
2003-04-16  9:33 ` Stephan von Krawczynski [this message]
2003-04-16 11:44   ` Arno Wilhelm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030416113302.1fef0dcc.skraw@ithnet.com \
    --to=skraw@ithnet.com \
    --cc=a.wilhelm@phion.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox