Re: [CHECKER] 6 memory leaks

William Lee Irwin III
2003-04-19T09:43:56Z

On Sat, Apr 19, 2003 at 12:44:45PM +0300, Muli Ben-Yehuda wrote:
> Index: net/irda/irttp.c
> ===================================================================
> RCS file: /home/cvs/linux-2.5/net/irda/irttp.c,v
> retrieving revision 1.12
> diff -u -r1.12 irttp.c
> --- net/irda/irttp.c 25 Feb 2003 05:02:46 -0000 1.12
> +++ net/irda/irttp.c 19 Apr 2003 08:50:00 -0000
> @@ -263,7 +263,7 @@
>
> IRDA_DEBUG(2, "%s(), rx_sdu_size=%d\n", __FUNCTION__,
> self->rx_sdu_size);
> - ASSERT(n <= self->rx_sdu_size, return NULL;);
> + ASSERT(n <= self->rx_sdu_size, {dev_kfree_skb(skb); return NULL;});
>
> /* Set the new length */
> skb_trim(skb, n);

I'm in terror. ASSERT()? return NULL in a macro argument?
Any chance of cleaning that up a bit while you're at it?

-- wli