Re: [CHECKER] 6 memory leaks

Muli Ben-Yehuda
2003-04-19T09:53:20Z

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Sat, Apr 19, 2003 at 02:55:26AM -0700, William Lee Irwin III wrote:
> On Sat, Apr 19, 2003 at 12:44:45PM +0300, Muli Ben-Yehuda wrote:
> > Index: net/irda/irttp.c
> > ===================================================================
> > RCS file: /home/cvs/linux-2.5/net/irda/irttp.c,v
> > retrieving revision 1.12
> > diff -u -r1.12 irttp.c
> > --- net/irda/irttp.c 25 Feb 2003 05:02:46 -0000 1.12
> > +++ net/irda/irttp.c 19 Apr 2003 08:50:00 -0000
> > @@ -263,7 +263,7 @@
> >
> > IRDA_DEBUG(2, "%s(), rx_sdu_size=%d\n", __FUNCTION__,
> > self->rx_sdu_size);
> > - ASSERT(n <= self->rx_sdu_size, return NULL;);
> > + ASSERT(n <= self->rx_sdu_size, {dev_kfree_skb(skb); return NULL;});
> >
> > /* Set the new length */
> > skb_trim(skb, n);
>
> I'm in terror. ASSERT()? return NULL in a macro argument?
> Any chance of cleaning that up a bit while you're at it?

I'm afraid it's rather wide-spread...

mulix@granada:~/kernel/cvs/linux-2.5$ grep ASSERT net/irda/*.c | grep return | wc -l
511

I'm willing to do the grunt work of converting it, if it's ok with the
IRDA maintainers.
--
Muli Ben-Yehuda
http://www.mulix.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]