public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Kevin P. Fleming" <kpfleming@cox.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.68 oops booting with initrd
Date: Mon, 21 Apr 2003 17:40:53 +0100	[thread overview]
Message-ID: <20030421174053.A8101@infradead.org> (raw)
In-Reply-To: <3EA41339.3090909@cox.net>; from kpfleming@cox.net on Mon, Apr 21, 2003 at 08:50:17AM -0700

On Mon, Apr 21, 2003 at 08:50:17AM -0700, Kevin P. Fleming wrote:
> The patch you supplied (check disk->minors != 1 before calling 
> devfs_remove_partitions) did not apply do 2.5.68; the code in 
> fs/partitions/check.c has changed since your base version. However, 
> hand-editing to do the same check has solved the problem.
> 
> I'll Christoph supply a patch, since he's the one that's been working in 
> that whole devfs area.

And 2.5.58-bk1 is completly different again but should have fixed it.

Make sure you apply the following diff when using devfs, though:


--- 1.1/fs/partitions/devfs.c	Sat Apr 19 20:57:36 2003
+++ edited/fs/partitions/devfs.c	Mon Apr 21 17:11:33 2003
@@ -81,7 +81,7 @@
 {
 	char dirname[64], symlink[16];
 
-	if (disk->devfs_name[0] != '\0')
+	if (disk->devfs_name[0] == '\0')
 		sprintf(disk->devfs_name, "%s/disc%d", disk->disk_name,
 				disk->first_minor >> disk->minor_shift);
 

      reply	other threads:[~2003-04-21 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-20  5:27 2.5.68 oops booting with initrd Kevin P. Fleming
2003-04-20 14:08 ` Kevin P. Fleming
2003-04-20 23:45 ` Herbert Xu
2003-04-21 15:50   ` Kevin P. Fleming
2003-04-21 16:40     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030421174053.A8101@infradead.org \
    --to=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kpfleming@cox.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox