From: Muli Ben-Yehuda <mulix@mulix.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Fix irq event debug print-out, and add stack dump which can
Date: Tue, 22 Apr 2003 10:29:04 +0300 [thread overview]
Message-ID: <20030422072904.GA7434@actcom.co.il> (raw)
In-Reply-To: <200304220713.h3M7DdRZ018542@hera.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Tue, Apr 22, 2003 at 06:05:40AM +0000, Linux Kernel Mailing List wrote:
> printk(retval
> ? "irq event %d: bogus retval mask %x\n"
> : "irq %d: nobody cared!\n",
> irq,
> retval);
Uhm, the first printk string takes two parameters, and the second one
only one parameter... how about this cosmetic patch? Better some
superflous information than printk params mismatch. Not tested,
obvious.
diff -u -r1.31 irq.c
--- arch/i386/kernel/irq.c 21 Apr 2003 20:10:51 -0000 1.31
+++ arch/i386/kernel/irq.c 22 Apr 2003 06:31:10 -0000
@@ -225,7 +225,7 @@
count--;
printk(retval
? "irq event %d: bogus retval mask %x\n"
- : "irq %d: nobody cared!\n",
+ : "irq %d: nobody cared! (retval %x)\n",
irq,
retval);
}
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
parent reply other threads:[~2003-04-22 7:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200304220713.h3M7DdRZ018542@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030422072904.GA7434@actcom.co.il \
--to=mulix@mulix.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox