* Re: Fix irq event debug print-out, and add stack dump which can
[not found] <200304220713.h3M7DdRZ018542@hera.kernel.org>
@ 2003-04-22 7:29 ` Muli Ben-Yehuda
0 siblings, 0 replies; only message in thread
From: Muli Ben-Yehuda @ 2003-04-22 7:29 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Tue, Apr 22, 2003 at 06:05:40AM +0000, Linux Kernel Mailing List wrote:
> printk(retval
> ? "irq event %d: bogus retval mask %x\n"
> : "irq %d: nobody cared!\n",
> irq,
> retval);
Uhm, the first printk string takes two parameters, and the second one
only one parameter... how about this cosmetic patch? Better some
superflous information than printk params mismatch. Not tested,
obvious.
diff -u -r1.31 irq.c
--- arch/i386/kernel/irq.c 21 Apr 2003 20:10:51 -0000 1.31
+++ arch/i386/kernel/irq.c 22 Apr 2003 06:31:10 -0000
@@ -225,7 +225,7 @@
count--;
printk(retval
? "irq event %d: bogus retval mask %x\n"
- : "irq %d: nobody cared!\n",
+ : "irq %d: nobody cared! (retval %x)\n",
irq,
retval);
}
--
Muli Ben-Yehuda
http://www.mulix.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] only message in thread