public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@linuxhacker.ru>
To: alan@redhat.com, torvalds@transmeta.com,
	linux-kernel@vger.kernel.org, marcelo@conectiva.com.br
Cc: r.e.wolff@bitwizard.nl
Subject: Fix for memleak in Perle Specialix driver
Date: Wed, 23 Apr 2003 00:08:15 +0400	[thread overview]
Message-ID: <20030422200815.GA7671@linuxhacker.ru> (raw)

Hello!

   There is a memleak on error exit path in Perle Specialix driver.
   The problem is present in both 2.4 and 2.5, the patch is trivial and
   applies to both trees.
   Please consider applying.

Bye,
    Oleg

===== drivers/char/rio/rioboot.c 1.3 vs edited =====
--- 1.3/drivers/char/rio/rioboot.c	Tue Feb  5 10:42:04 2002
+++ edited/drivers/char/rio/rioboot.c	Tue Apr 22 23:50:56 2003
@@ -328,6 +328,7 @@
 
 			if ( copyin((int)rbp->DataP,DownCode,rbp->Count)==COPYFAIL ) {
 				rio_dprintk (RIO_DEBUG_BOOT, "Bad copyin of host data\n");
+				sysfree( DownCode, rbp->Count );
 				p->RIOError.Error = COPYIN_FAILED;
 				func_exit ();
 				return EFAULT;

                 reply	other threads:[~2003-04-22 19:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030422200815.GA7671@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=r.e.wolff@bitwizard.nl \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox