Re: PATCH: some additional unusual_devs-entries for usb-storage-driver, kernel 2.5.68

Greg KH
2003-04-23T01:43:50Z

On Wed, Apr 23, 2003 at 01:45:08AM +0100, Dave Jones wrote:
> On Tue, Apr 22, 2003 at 02:32:47PM -0700, Greg KH wrote:
> > On Mon, Apr 21, 2003 at 09:48:05PM +0200, Hanno B?ck wrote:
> > > This patch against 2.5.68 adds support for some digital cameras.
> > > Same patch is already applied to the 2.4-ac-series.
> > > It is taken from the lycoris kernel-source.
> >
> > Ok, in talking with the usb-storage author, I'll be accepting all
> > unushal_devs.h patches now, as long as they contain the following:
> > - a comment above the entry with a email address of someone who
> > has this device that this entry fixes the driver for them.
> > This is to allow us to possibly remove entries at a later time
> > if the core changes, and get a verification that it's ok to do
> > so.
> > - a copy of the /proc/bus/usb/devices device entry with the
> > device plugged in and the driver loaded (this should not be in
> > the patch, but in the body of the email.)
> >
> > So, if there are any outstanding drivers/usb/storage/unusual_devs.h
> > entries that people have floating around, sent them on!
>
> I've been carrying these for _moons_. The only reason I've never punted
> them on is that the US_FL_SL_IDE_BUG bit is odd (nothing seems to use
> it, so at some point, I must have dropped the other half of the diff).

Hm, that is strange, I'll ignore that part of the patch :)

And what are the odds of getting /proc/bus/usb/devices from those email
addresses? I'll try offline to collect them.

thanks,

greg k-h